Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Opaque Background to NavigationView ContentGrid #4707

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

karkarl
Copy link
Contributor

@karkarl karkarl commented Apr 1, 2021

Description

Add opaque background to NavView ContentGrid to ensure that it looks correct.

image

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Apr 1, 2021
@karkarl
Copy link
Contributor Author

karkarl commented Apr 1, 2021

/azp run

@karkarl karkarl requested a review from YuliKl April 1, 2021 00:16
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl karkarl requested a review from jevansaks April 1, 2021 00:16
@StephenLPeters
Copy link
Contributor

Do you have before and after pictures?

@StephenLPeters
Copy link
Contributor

@karenbtlai merging master should resolve the VerifyAllThemesContainSameResourceKeys test failure

@karkarl karkarl force-pushed the user/karenlai/UpdateNavViewContentBackground branch from ce3e9e6 to 23d84cb Compare April 1, 2021 20:50
@karkarl
Copy link
Contributor Author

karkarl commented Apr 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ranjeshj ranjeshj added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Apr 1, 2021
@karkarl karkarl merged commit 8fc91ee into master Apr 2, 2021
@karkarl karkarl deleted the user/karenlai/UpdateNavViewContentBackground branch April 2, 2021 17:13
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 3, 2023
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants