Fix the animated icon foreground. #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@chingucoding fyi |
StephenLPeters
added
area-AnimatedIcon
team-Controls
|
Huh interesting that this happens. Thanks for pinging me on this @StephenLPeters ! Regarding the second case, shouldn't we be able to listen to the changes of that brush too? Or does the AnimIcon not know the foreground if it get's propagated during the initial rendering? If the initial pass fails, could we just walk up to the tree to get the correct value? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
May 3, 2021
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change AnimatedIcon would respond to its foreground property changing to a new value, but it would not respond to its foreground property mutating. Because the foreground brush isn't actually used, but instead we pass the color property from it (if its a solid color brush) to the composition visuals, we actually need to be informed when the color property changes, so now we attach a handler to that property changed event.
There is still an issue however. Foreground is a propagating property, meaning that if foreground isn't set on AnimatedIcon directly, the system will use the foreground of the nearest ancestor with the property set. The system will raise a property changed notification to animated icon when the foreground property changes, but not when it mutates. So, even with this change, we wont respond when using an ancestors foreground and the color within that foreground changes. If anyone has an idea about how to fix this I'm all ears!