Adding styles for the system XAML CommandBarFlyoutCommandBar #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dBar styles were in the style XAMLs instead of the theme resource XAMLs, which made it so they couldn't be derived from. - Fixed an issue where CornerRadius wasn't being properly animated. - Added styles for the WUXC version of CommandBarFlyoutCommandBar.
ghost
added
the
…ommandBarFlyoutStyle
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
added
area-Commanding
|
@llongley can you please resolve the conflicts ? |
…ommandBarFlyoutStyle
…ce it needs fixes there to work properly.
|
Conflicts resolved. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ommandBarFlyoutStyle
… 19H1. Adding it back to avoid that assert.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Moving the named style from the xaml file to the resources file does have more effect than just making the resource exposable. It changes where the StaticResource invokations originate from, which changes the resource lookup behavior. This could potentially cause some resouce overrides which worked before this change to no longer work. But it seems like you need the based on behavior so I think we need to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we add the ability to retrieve the monitor bounds from a UI element, some apps are going to need to use the system XAML CommandBarFlyout to get that functionality, so this adds styles for that control's CommandBar in order to get the WinUI 2 experience from it.
While I was here, there were also two issues I needed to fix: