PipsPager scrolling fix event bubble up #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@gabbybilka FYI |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
requested changes
Mar 20, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Mar 22, 2021
StephenLPeters
removed
the
needs-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PipsPager inner ScrollViewer causes outer ScrollViewers scroll if the inner ScrollViewer cannot fully fulfill the scroll request. It happens when offsets are bigger than what ScrollViewer can actually scroll by.
Motivation and Context
This PR closes #4246. It handles the
BringIntoViewRequestedevent and stops its bubbling up.How Has This Been Tested?
Manually.