Fix MUX CommandBar style not being applied to TextControl flyouts. #4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ranjeshj
added
area-Commanding
|
@StephenLPeters can you merge in master ? |
|
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text Control Flyouts were referencing a TextCommandBarFlyout by static resource references. These resources were only defined in the system's Generic.xaml. System xaml only has Windows.UI.Xaml.TextCommandBarFlyout which references Wux command bar flyout. We need a MUX.TextCommandBarFlyout for these controls to have flyouts with our command bar flyout style updates. Thus we add these resources in XamlControlsResources.
Fixes #4472