Fix TeachingTip title and sub title not being initially collapsed. #4494

StephenLPeters · 2021-03-12T00:59:14Z

Set Title and Subtitle TextBlocks visibility to collapsed in OnApplyTemplate if they are empty. Add a test.

…emplate if they are empty. Add a test.

StephenLPeters · 2021-03-12T00:59:46Z

/azp run

azure-pipelines · 2021-03-12T01:00:03Z

Azure Pipelines successfully started running 1 pipeline(s).

marcelwgn · 2021-03-12T08:18:31Z

What about #3397? They both address the same underlying issues, however #3397 uses an API test instead of an interaction test to catch regressions.

StephenLPeters · 2021-03-12T19:42:05Z

ugh, I didn't realize you had already solved this issue... This is a great example of why our current PR state is so bad

StephenLPeters · 2021-03-12T19:44:55Z

I like your PR better, specifically using VSM to set the visibility.

marcelwgn · 2021-03-12T19:51:53Z

ugh, I didn't realize you had already solved this issue... This is a great example of why our current PR state is so bad

Once all open PRs have been merged, I think this won't be an issue anymore.

Set Title and Subtitle TextBlocks visibility to collapsed in OnApplyT…

0f3209b

…emplate if they are empty. Add a test.

ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 12, 2021

StephenLPeters closed this Mar 12, 2021

StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Mar 13, 2021

Provide feedback