Add an example of how to use use animated icon within a content control that is not the direct (logical) child. #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol that is not the direct (logical) child.
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
reviewed
Mar 4, 2021
| HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}" | ||
| VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}" | ||
| AutomationProperties.AccessibilityView="Raw" | ||
| controls:AnimatedIcon.State="{Binding (controls:AnimatedIcon.State), Mode=TwoWay, RelativeSource={RelativeSource TemplatedParent}}"> |
There was a problem hiding this comment.
could you add some comments here on how this is working and the wireup involved.
ranjeshj
reviewed
Mar 4, 2021
| @@ -539,6 +640,18 @@ | |||
| </Viewbox> | |||
| <TextBlock x:Name="LastTransitionTextBlock"/> | |||
| </StackPanel> | |||
|
|
|||
| <StackPanel Background="Gray"> | |||
There was a problem hiding this comment.
nit: could move the style down into this StackPanel to keep the two together. its hard to know that the implicit button style about is what makes this scenario work.
ranjeshj
added
area-AnimatedIcon
team-Controls
ranjeshj
approved these changes
Mar 4, 2021
… add comments to the templates
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnimatedIcon works by default if a templated content control sets the state property on the direct parent of the animated icon. However sometimes you have a content control and want to make the animated icon a (non-direct) descendent of the control. This adds an example of how you could do that with the current design.