NavigationView: Fix issue where disabling settings would still show gap #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
StephenLPeters
added
area-NavigationView
ranjeshj
reviewed
Feb 19, 2021
ranjeshj
reviewed
Feb 19, 2021
|
@chingucoding can you merge with master ? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
reviewed
Apr 7, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…acing-fix' of github.com:chingucoding/microsoft-ui-xaml into user/chingucoding/navigationview-no-settings-spacing-fix
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…x' of github.com:chingucoding/microsoft-ui-xaml into user/chingucoding/navigationview-no-settings-spacing-fix
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beervoley
approved these changes
Apr 8, 2021
|
@chingucoding thanks for your help!!! |
marcelwgn
deleted the
user/chingucoding/navigationview-no-settings-spacing-fix
branch
|
Pleasure helping out! Thank you @beervoley in assisting this PR! |
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 8, 2023
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove min-height setters as those didn't do anything and update layouting logic to handle cases where one of the collections is empty correctly.
@carlos-zamora FYI :)
Motivation and Context
Closes #3900
Closes #3771
How Has This Been Tested?
Add two new interaction tests. The test page has also been updated to have the tests run a bit faster since we hit "breaking" conditions earlier. As part of that, I needed to adjust some numbers in existing tests.
Screenshots (if appropriate):