Visual updates to expander #4024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashatitova
requested review from
licanhua,
StephenLPeters,
karkarl,
beervoley,
teaP and
marksfoster
ghost
added
the
beervoley
added
area-Expander
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
requested changes
Jan 27, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marksfoster
approved these changes
Jan 27, 2021
ranjeshj
reviewed
Jan 28, 2021
|
Please merge in master to get a fix for the failing tests. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
What is the thinking behind the large padding above and below the heading text. The padding around the close button visual is uneven too, which will not look good with the hover and pressed state backing plates. |
karkarl
reviewed
Jan 28, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
reviewed
Jan 28, 2021
karkarl
reviewed
Jan 28, 2021
karkarl
reviewed
Jan 28, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
approved these changes
Jan 28, 2021
|
Why is the expander using so much padding top and bottom?
and not closer in line with the ComboBox and DropDownButton controls?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expander control was pretty basic so added styles to it.
Future work: - Pop out animations updates
Screenshots:
Light: regular/hover/press
Dark: regular/hover/press
NOTE: for high contrast, I'm using custom ButtonText and ButtonFace colors for the header/toggle, to make sure they are differentiating from WindowText + WindowColor for the drop down
Regular/hover + press (these two look the same)