Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CalendarDatePicker style #4001

Merged
merged 7 commits into from
Jan 26, 2021

Conversation

beervoley
Copy link
Contributor

@beervoley beervoley commented Jan 22, 2021

Description

This PR updates the picker form control to use new colors.

Screenshots (if appropriate):

image

image

@beervoley beervoley added area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView team-Controls Issue for the Controls team labels Jan 22, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 22, 2021
@beervoley beervoley removed the needs-triage Issue needs to be triaged by the area owners label Jan 22, 2021
@mdtauk
Copy link
Contributor

mdtauk commented Jan 22, 2021

Are these visual changes, or just some under the hood stuff. if visual, screenshots would be appreciated.

I am guessing this is for the picker form control, and not about the CalendarView control itself?

@beervoley
Copy link
Contributor Author

@mdtauk just the visuals, and yes, this PR has only updates for picker form control

@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft microsoft deleted a comment from azure-pipelines bot Jan 22, 2021
@microsoft microsoft deleted a comment from azure-pipelines bot Jan 22, 2021
@microsoft microsoft deleted a comment from azure-pipelines bot Jan 22, 2021
@microsoft microsoft deleted a comment from azure-pipelines bot Jan 22, 2021
@ranjeshj
Copy link
Contributor

@beervoley can you share a pic ?

@beervoley
Copy link
Contributor Author

@ranjeshj @mdtauk screenshots attached

@mdtauk
Copy link
Contributor

mdtauk commented Jan 23, 2021

This looks like a bug
image

The middle control, why is there so much space after the Calendar Icon? The header should overhang, but the control should wrap to contain the date and icon right?

@beervoley
Copy link
Contributor Author

@mdtauk, yup, it is indeed weird. I didn't modify anything beside the colors. These bugs (if they are bugs indeed) must've been there before. I will have a look in a bit:)

@thexamlguy
Copy link

@mdtauk, yup, it is indeed weird. I didn't modify anything beside the colors. These bugs (if they are bugs indeed) must've been there before. I will have a look in a bit:)

I can repro the issue in a UWP app without WinUI:

image

The issue only seems to appear when you host the CalendarDatePicker inside a StackPanel with Orientation set to Horizontal. The problem appears to away if you set the StackPanel Orientation to Vertical though however.

image

@ranjeshj ranjeshj requested a review from YuliKl January 25, 2021 15:04
@karkarl
Copy link
Contributor

karkarl commented Jan 25, 2021

[Windows.UI.Xaml.Controls.Grid]

What's happening with these files?


Refers to: test/MUXControlsTestApp/verification/ContentDialog-5.xml:1 in 07f6465. [](commit_id = 07f6465, deletion_comment = True)

@beervoley
Copy link
Contributor Author

[Windows.UI.Xaml.Controls.Grid]

What's happening with these files?

Refers to: test/MUXControlsTestApp/verification/ContentDialog-5.xml:1 in 07f6465. [](commit_id = 07f6465, deletion_comment = True)

pipeline returned the new visual verification files so I updated them :)

@beervoley
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley requested a review from ranjeshj January 26, 2021 03:45
@ranjeshj ranjeshj merged commit 4289186 into master Jan 26, 2021
@ranjeshj ranjeshj deleted the user/vsiliush/fix-calendar-placeholder branch January 26, 2021 16:45
@mdtauk
Copy link
Contributor

mdtauk commented Jan 27, 2021

This is how the CalendarDatePicker could look with my pre-emptive Calendar Flyout design idea #4010

image

Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 7, 2022
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DateTimePickers DatePicker, TimePicker, CalendarDatePicker, CalendarView team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants