ContentDialog visual update

[tashatitova]

Updating the brushes, animations, layout logic

[mdtauk]

Could you post a Light and Dark image showing the new visual style?

Also what do your layout logic changes mean for developers?

[tashatitova]

Could you post a Light and Dark image showing the new visual style?

Also what do your layout logic changes mean for developers?

Added screenshots.

The logic changes nothing for the developers. Just makes 2-3 column layout logic cleaner with additional fixed columns for spacing, which is stored as a resource and can be easily updated in one spot should we need this later.

[mdtauk]

Could you post a Light and Dark image showing the new visual style?
Also what do your layout logic changes mean for developers?

Added screenshots.

The logic changes nothing for the developers. Just makes 2-3 column layout logic cleaner with additional fixed columns for spacing, which is stored as a resource and can be easily updated in one spot should we need this later.

Thank you for the visuals, that bottom darker bar with the buttons makes a huge difference (design and aesthetic wise)
Has some stuff in common with the Win32 Dialogs too.

[ranjeshj]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[marksfoster]

Format nit: move x:Name to new line

[harvinders]

Currently increasing the width of the dialog also increases the width of the button. Say, at the width 1000 for content dialog, a single button looks odd (too stretched). Are we going to look into that too here?

[tashatitova]

Currently increasing the width of the dialog also increases the width of the button. Say, at the width 1000 for content dialog, a single button looks odd (too stretched). Are we going to look into that too here?

This will be a separate bug as it's not a regression. @stmoy is there an open issue at the moment?

[tashatitova]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mdtauk]

Currently increasing the width of the dialog also increases the width of the button. Say, at the width 1000 for content dialog, a single button looks odd (too stretched). Are we going to look into that too here?

This will be a separate bug as it's not a regression. @stmoy is there an open issue at the moment?

This could be done as a behaviour on the ContentDialog. To have the bottom buttons stretch to fill the width, or to align to the right (or the left with Right To Left flow)

[stmoy]

Currently increasing the width of the dialog also increases the width of the button. Say, at the width 1000 for content dialog, a single button looks odd (too stretched). Are we going to look into that too here?

This will be a separate bug as it's not a regression. @stmoy is there an open issue at the moment?

This is "by design" so no bug is filed - the main reason is that ContentDialogs are expected to always have at least two buttons link. In that context, it's not a huge deal that a single button dialog looks strange because there shouldn't be any single button dialogs.

That said, @mdtauk posted a reasonable one-button dialog so it might be reasonable to reassess the guidance. This should be reassessed separately from this PR though.

[mdtauk]

Currently increasing the width of the dialog also increases the width of the button. Say, at the width 1000 for content dialog, a single button looks odd (too stretched). Are we going to look into that too here?

This will be a separate bug as it's not a regression. @stmoy is there an open issue at the moment?

This is "by design" so no bug is filed - the main reason is that ContentDialogs are expected to always have at least two buttons link. In that context, it's not a huge deal that a single button dialog looks strange because there shouldn't be any single button dialogs.

That said, @mdtauk posted a reasonable one-button dialog so it might be reasonable to reassess the guidance. This should be reassessed separately from this PR though.

What about a single button, but also beside it, a Hyperlink Button?

[mdtauk]

@tashatitova There is possibly an issue with the new ContentDialog design. The bottom part of the dialog, with the buttons in, seems to darken whilst the dialog transitions on and off screen.

Stills from a screen recording

The final frames of the dialog transition, appears jarring.