Add ImageIcon #3629

StephenLPeters · 2020-11-18T02:51:09Z

Bitmap Icon has a URI source property which doesn't allow you to put an SvgImageSource into a bitmap icon. To support this scenario we'll add a new IconElement, ImageIcon which has a ImageSource property instead.

Fixes #3323

StephenLPeters · 2020-11-18T02:51:19Z

/azp run

azure-pipelines · 2020-11-18T02:51:30Z

Azure Pipelines successfully started running 1 pipeline(s).

ranjeshj · 2020-11-18T12:56:56Z

@bschoepke as FYI

jevansaks · 2020-11-18T17:10:46Z

test/MUXControlsTestApp/MUXControlsTestApp.Shared.projitems

@@ -152,6 +152,7 @@
    </ProjectReference>
  </ItemGroup>
  <ItemGroup>
+    <Content Include="$(MSBuildThisFileDirectory)Assets\Nuclear_symbol.svg" />


Nuclear_symbol [](start = 56, length = 14)

only using Nuclear_symbol, can you delete Victorian-Vortex?

yes, thank you

jevansaks · 2020-11-18T17:14:50Z

dev/IconSource/IconSource.idl

+    ImageIconSource();
+
+    Windows.UI.Xaml.Media.ImageSource ImageSource{ get; set; };
+


Since we have the BitmapIconSource type defined here and we can change it, should we just be adding these properties on there? The only reason we're not enhancing BitmapIcon in the OS was because of the OS APIs not going downlevel.

Interesting so if BitmapIconSource's ImageSource was not a UriSource what would we do? create an ImageIcon instead?

I'm not sure, I actually don't know enough about how that converter function works to say if it would work that way. Or maybe always just create ImageIcon?

In that case would/could we delete the ImageIconSource? I think that might be confusing

Lets keep ImageIconSource for now and follow up in the spec review.

jevansaks · 2020-11-18T17:15:44Z

dev/ImageIcon/ImageIcon.cpp

+void ImageIcon::OnApplyTemplate()
+{
+    Loaded({ this, &ImageIcon::OnLoaded });
+}


If you call the base then by the time it comes back you should have the visual tree populated, right? If not please add a comment as to why you're waiting for Loaded.

jevansaks

Approved with suggestions.

StephenLPeters · 2020-11-20T22:29:48Z

/azp run

azure-pipelines · 2020-11-20T22:29:59Z

Azure Pipelines successfully started running 1 pipeline(s).

dev/ImageIcon/APITests/ImageIconTests.cs

StephenLPeters · 2020-11-24T02:56:05Z

/azp run

azure-pipelines · 2020-11-24T02:56:21Z

Azure Pipelines successfully started running 1 pipeline(s).

StephenLPeters · 2020-11-24T19:30:29Z

/azp run

azure-pipelines · 2020-11-24T19:30:45Z

Azure Pipelines successfully started running 1 pipeline(s).

mdtauk · 2020-11-24T20:23:41Z

Is this only for strictly image types, so JPG, PNG, SVG, GIF?

What about ICO format icons? If these are supported, how do you choose the ICO size/format?

jevansaks · 2020-11-24T20:29:35Z

What about ICO format icons? If these are supported, how do you choose the ICO size/format?

The goal here is to get the IconElement family of things on equal footing with the Image element. Currently you can't load all the same types that Image element supports in IconElement.

Your question applies equally about ICO files to the Image element, and I don't think it's well-supported. XAML uses WIC to load images and so if ICO is supported there, XAML will do something. But, as you say, there's questions about which size of ICO to load out and I imagine that doesn't work great ... but it's a separate issue.

mdtauk · 2020-11-24T20:48:39Z

What about ICO format icons? If these are supported, how do you choose the ICO size/format?

The goal here is to get the IconElement family of things on equal footing with the Image element. Currently you can't load all the same types that Image element supports in IconElement.

Your question applies equally about ICO files to the Image element, and I don't think it's well-supported. XAML uses WIC to load images and so if ICO is supported there, XAML will do something. But, as you say, there's questions about which size of ICO to load out and I imagine that doesn't work great ... but it's a separate issue.

I would assume it falls under WinUI rather than Project Reunion. It may be important to support these formats, especially for the transition story from GDI/WinForms and MFC to WinUI. Existing icon assets can be preserved (although it may be preferable to move to modern SVG icon designs)

If you are making a Bitmap Icon, then ICO should be considered. They are essentially a collection of Bitmap images combined - but maybe you could consider a TargetSize property - which could act as a guide for non ICO files?

And to ANI files get supported? I know old Win32 progress dialogs use them, as well as their intended use for Animated Cursors.

OldNewThing discussing ICO format

Old MSDN Documentation

* Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu (#3082) * Fix corner radius for the overflow menu and the children flyout menu. * Add two interaction tests. * Small comment improvements. * Small comment improvement. * Move top NavigationView specific overflow button tests from CommonTests to TopModeTests. * Now close opened flyout in API test before finishing. * Rename FindElementOfTypeInParentTree -> FindVisualParentByType * Add missing resource files to LocConfig (#3567) * Cache IsFullScreenMode and invalidate the value only when SizeChanged is raised (#3569) * Fix issue with ProgressRing not acting correctly when moving backwards (#3565) * Add workaround for awkward progress ring behavior. * Update progresring backwards behavior * move pager resources under strings/en-us folder (#3593) * make footer menu items public (#3519) * update progress ring idl (#3599) * TabView: Fix newly-added items not respecting TabWidthMode [compact] when using an ItemsSource collection (#3118) * Fix the following issues when populating the TabView via its ItemsSource API: * crash when clearing the ItemsSource * TabWidthMode [compact] being ignored in XAML Markup and for newly-added items * small comment improvement * Added two API tests and modified existing test. * Unrelated code which was commented out is run again. * Add API test. * Simplified API test. * Merge API tests. * Add API contract checks for corner radius. * Ensure that listview selected index is not outside of the item range. * Update TabView.cpp Co-authored-by: Ranjesh <[email protected]> * Switch to using ThemeResource for icon in InfoBar (#3603) * Allow winui to detect if it's in CBS package (#3520) * build cbs * Revert "build cbs" This reverts commit 24b6812. * cbs: * Update dev/dll/SharedHelpers.cpp Co-authored-by: Jevan Saks <[email protected]> * Update dev/dll/XamlControlsResources.cpp Co-authored-by: Jevan Saks <[email protected]> * remove check for old platform and add assert * make pipeline build cbs resources.pri and manifest * Update dev/dll/XamlControlsResources.cpp * Update dev/dll/XamlControlsResources.cpp * fail fast * Update dev/dll/XamlControlsResources.cpp * fix package name when generate CBSManifest Co-authored-by: Jevan Saks <[email protected]> * Doc/roadmap updates (#3618) * Updating ordering * Updating feature roadmap * More updates to feature roadmap, roadmap graphic * Update bug_report.md (#3622) * Fix readme to mention Preview 3 instead of P2 (#3621) * Update NavigationView pane scrolling behavior (#3602) * Add initial layout updating, add test page * Add first interaction tests * Fix behavior, add scrolling behavior * CR feedback * Add hacky workaround for weird sizing behavior * Update layout, add separator * Fix updating behavior * Remove hacky workaround, fix test * Add fault tolerance to tests * Update verification files * Change Preview 2 to Preview 3 (#3626) * Update preview_upgrade_instructions.md (#3636) * TeachingTip: Fix background for light-dismissable tip (#3440) * Add missing visual state setters. * Extend API test. * update loc strings (#3650) * File Pipeline build break: Update Nuget from 5.2 to 5.8 (#3664) * Fixing an issue where we needed a FileWrites to avoid file deletion. (#3661) * Remove explicit sizes of InfoBar (#3653) * Remove explicit sizes of InfoBar * Set minheight for centering * Switch to lightweight styling resources * Update CommandBarFlyout closing animation to include button moving (#3594) * Update more-button animation behavior * Fix background issue * CR feedback * update intellisense file (#3651) * Update AcrylicBrushes and add new AcrylicBrushes (#3498) * Add new brushes, update CommandbarFlyout and NavigationView to use new brushes * Update brushes * Update brush references * Update project file * Update navigationview resources * Hacky workaround XAML compiler bug * Add check * Add comment * Fix typo * Add ImageIcon (#3629) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Fix Innerloop Solution (#3697) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Add preprocessor declaration around imageIconSource code in MakeIconElementFrom * Update InfoBarPanel API names (#3704) * Update API names * Remove grid.columns * Adding PipsPager (#3592) * PipsControl initial structure * PipsControl update file structure * Add boilerplate code * Add styles and update logic * Remove Grid inside the PipsControl * some layout fixes * Update common styles * Fix nav buttons visibility logic * Update themeresources and fix infinite scrolling * Clean up the code * Remove InneLoopAreasProps from PR * Add automation * Update resources file * Fix button visibility for automation * Fix navigaiton buttons disappearing bug * Update .idl file and add style as properties * Add handlers for button visibility changes * Add style handlers and update accessibility * Add basic test with flipview * Fix update of max number of pages * Fix maxdisplayedpages onchange handler and address small PR issues * remove commented code * Update Naming * Fix naming and fix pointer hover event * Update Tests and leave some comments * Update naming and tests * Fix sv change size and override virtual methods * Address PR comments * Address PR issues * Fix button not showing up on initial launch * Clean up the code * Update API tests * Partially Update Tests * Fix spacing * Update Strings * Attempt to fix tests * Attempt to fix tests * Fall back to manual scroll if fresh API is not available * Move API check to SharedHelpers * Fix naming Co-authored-by: Ranjesh Jaganathan <[email protected]> * fix tests * ImageIcon test fix Co-authored-by: Keith Mahoney <[email protected]> Co-authored-by: Stephen L Peters <[email protected]> Co-authored-by: Marcel Wagner <[email protected]> Co-authored-by: Felix-Dev <[email protected]> Co-authored-by: Tony Xia <[email protected]> Co-authored-by: EJ <[email protected]> Co-authored-by: T Paine <[email protected]> Co-authored-by: Jevan Saks <[email protected]> Co-authored-by: Canhua Li <[email protected]> Co-authored-by: Ana Wishnoff <[email protected]> Co-authored-by: Morten Nielsen <[email protected]> Co-authored-by: Thomas Claudius Huber <[email protected]> Co-authored-by: Luke Longley <[email protected]> Co-authored-by: Vsevolod <[email protected]>

…e 2.5 (#3887) * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * merge master into feature branch (#3556) * Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). Co-authored-by: Keith Mahoney <[email protected]> Co-authored-by: Stephen L Peters <[email protected]> Co-authored-by: Marcel Wagner <[email protected]> Co-authored-by: Felix-Dev <[email protected]> Co-authored-by: Tony Xia <[email protected]> Co-authored-by: EJ <[email protected]> * update controls to use design token colors, update styles (#3728) * merge master into feature branch (#3734) * Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu (#3082) * Fix corner radius for the overflow menu and the children flyout menu. * Add two interaction tests. * Small comment improvements. * Small comment improvement. * Move top NavigationView specific overflow button tests from CommonTests to TopModeTests. * Now close opened flyout in API test before finishing. * Rename FindElementOfTypeInParentTree -> FindVisualParentByType * Add missing resource files to LocConfig (#3567) * Cache IsFullScreenMode and invalidate the value only when SizeChanged is raised (#3569) * Fix issue with ProgressRing not acting correctly when moving backwards (#3565) * Add workaround for awkward progress ring behavior. * Update progresring backwards behavior * move pager resources under strings/en-us folder (#3593) * make footer menu items public (#3519) * update progress ring idl (#3599) * TabView: Fix newly-added items not respecting TabWidthMode [compact] when using an ItemsSource collection (#3118) * Fix the following issues when populating the TabView via its ItemsSource API: * crash when clearing the ItemsSource * TabWidthMode [compact] being ignored in XAML Markup and for newly-added items * small comment improvement * Added two API tests and modified existing test. * Unrelated code which was commented out is run again. * Add API test. * Simplified API test. * Merge API tests. * Add API contract checks for corner radius. * Ensure that listview selected index is not outside of the item range. * Update TabView.cpp Co-authored-by: Ranjesh <[email protected]> * Switch to using ThemeResource for icon in InfoBar (#3603) * Allow winui to detect if it's in CBS package (#3520) * build cbs * Revert "build cbs" This reverts commit 24b6812. * cbs: * Update dev/dll/SharedHelpers.cpp Co-authored-by: Jevan Saks <[email protected]> * Update dev/dll/XamlControlsResources.cpp Co-authored-by: Jevan Saks <[email protected]> * remove check for old platform and add assert * make pipeline build cbs resources.pri and manifest * Update dev/dll/XamlControlsResources.cpp * Update dev/dll/XamlControlsResources.cpp * fail fast * Update dev/dll/XamlControlsResources.cpp * fix package name when generate CBSManifest Co-authored-by: Jevan Saks <[email protected]> * Doc/roadmap updates (#3618) * Updating ordering * Updating feature roadmap * More updates to feature roadmap, roadmap graphic * Update bug_report.md (#3622) * Fix readme to mention Preview 3 instead of P2 (#3621) * Update NavigationView pane scrolling behavior (#3602) * Add initial layout updating, add test page * Add first interaction tests * Fix behavior, add scrolling behavior * CR feedback * Add hacky workaround for weird sizing behavior * Update layout, add separator * Fix updating behavior * Remove hacky workaround, fix test * Add fault tolerance to tests * Update verification files * Change Preview 2 to Preview 3 (#3626) * Update preview_upgrade_instructions.md (#3636) * TeachingTip: Fix background for light-dismissable tip (#3440) * Add missing visual state setters. * Extend API test. * update loc strings (#3650) * File Pipeline build break: Update Nuget from 5.2 to 5.8 (#3664) * Fixing an issue where we needed a FileWrites to avoid file deletion. (#3661) * Remove explicit sizes of InfoBar (#3653) * Remove explicit sizes of InfoBar * Set minheight for centering * Switch to lightweight styling resources * Update CommandBarFlyout closing animation to include button moving (#3594) * Update more-button animation behavior * Fix background issue * CR feedback * update intellisense file (#3651) * Update AcrylicBrushes and add new AcrylicBrushes (#3498) * Add new brushes, update CommandbarFlyout and NavigationView to use new brushes * Update brushes * Update brush references * Update project file * Update navigationview resources * Hacky workaround XAML compiler bug * Add check * Add comment * Fix typo * Add ImageIcon (#3629) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Fix Innerloop Solution (#3697) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Add preprocessor declaration around imageIconSource code in MakeIconElementFrom * Update InfoBarPanel API names (#3704) * Update API names * Remove grid.columns * Adding PipsPager (#3592) * PipsControl initial structure * PipsControl update file structure * Add boilerplate code * Add styles and update logic * Remove Grid inside the PipsControl * some layout fixes * Update common styles * Fix nav buttons visibility logic * Update themeresources and fix infinite scrolling * Clean up the code * Remove InneLoopAreasProps from PR * Add automation * Update resources file * Fix button visibility for automation * Fix navigaiton buttons disappearing bug * Update .idl file and add style as properties * Add handlers for button visibility changes * Add style handlers and update accessibility * Add basic test with flipview * Fix update of max number of pages * Fix maxdisplayedpages onchange handler and address small PR issues * remove commented code * Update Naming * Fix naming and fix pointer hover event * Update Tests and leave some comments * Update naming and tests * Fix sv change size and override virtual methods * Address PR comments * Address PR issues * Fix button not showing up on initial launch * Clean up the code * Update API tests * Partially Update Tests * Fix spacing * Update Strings * Attempt to fix tests * Attempt to fix tests * Fall back to manual scroll if fresh API is not available * Move API check to SharedHelpers * Fix naming Co-authored-by: Ranjesh Jaganathan <[email protected]> * fix tests * ImageIcon test fix Co-authored-by: Keith Mahoney <[email protected]> Co-authored-by: Stephen L Peters <[email protected]> Co-authored-by: Marcel Wagner <[email protected]> Co-authored-by: Felix-Dev <[email protected]> Co-authored-by: Tony Xia <[email protected]> Co-authored-by: EJ <[email protected]> Co-authored-by: T Paine <[email protected]> Co-authored-by: Jevan Saks <[email protected]> Co-authored-by: Canhua Li <[email protected]> Co-authored-by: Ana Wishnoff <[email protected]> Co-authored-by: Morten Nielsen <[email protected]> Co-authored-by: Thomas Claudius Huber <[email protected]> Co-authored-by: Luke Longley <[email protected]> Co-authored-by: Vsevolod <[email protected]> * add missing PipsPager generatd file (#3755) * Allow microsoft-ui-xaml to support multiple sets of styles (#3690) * update customtask * update project to use the customtool and support UseVisualStyle * support new flag in api * missing one file change for custombuild task * update to new api and address some comments * fix the -> * script to move master xaml to v2.5 and add them to proj * manually correct the missing items * vcxproj back to UTF8 * standard the name and replace previous with 2dot5 * batch remove last line for project * remove pips and address commentss * trim last line * remove newline at the end of file * fix ##[error]dev\dll\XamlControlsResources.cpp(249,0): Error C26449: gsl::span or std::string_view created from a temporary will be invalid when the temporary is invalidated (gsl.view). * remove return type in lambda * remove Expander_v2.5.xaml, move merge.bat to tools and fix the test failure * fix test * Fix RadioButtons colouring bug (#3756) * fix radioButtons colouring bug * changes from comments * Slider Visual Update (#3768) * visual update * re-add missing key * add innerthumb size animation * add colour transitions * changes from comments * colour transitions fix * prepare for merge * Update pfx and cer used for test signing (#3882) * update pfx * update CalendarView.xml master * update default setting and codegen update avoid crash on expander, reveal, NavView and progressbar * resolve merge conflict * enable test * Fix the Latest still using 2.5 styles Co-authored-by: T Paine <[email protected]> Co-authored-by: Ranjesh <[email protected]> Co-authored-by: Keith Mahoney <[email protected]> Co-authored-by: Stephen L Peters <[email protected]> Co-authored-by: Marcel Wagner <[email protected]> Co-authored-by: Felix-Dev <[email protected]> Co-authored-by: Tony Xia <[email protected]> Co-authored-by: EJ <[email protected]> Co-authored-by: Jevan Saks <[email protected]> Co-authored-by: Ana Wishnoff <[email protected]> Co-authored-by: Morten Nielsen <[email protected]> Co-authored-by: Thomas Claudius Huber <[email protected]> Co-authored-by: Luke Longley <[email protected]> Co-authored-by: Vsevolod <[email protected]> Co-authored-by: Karen Lai <[email protected]>

* Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu (#3082) * Fix corner radius for the overflow menu and the children flyout menu. * Add two interaction tests. * Small comment improvements. * Small comment improvement. * Move top NavigationView specific overflow button tests from CommonTests to TopModeTests. * Now close opened flyout in API test before finishing. * Rename FindElementOfTypeInParentTree -> FindVisualParentByType * Add missing resource files to LocConfig (#3567) * Cache IsFullScreenMode and invalidate the value only when SizeChanged is raised (#3569) * Fix issue with ProgressRing not acting correctly when moving backwards (#3565) * Add workaround for awkward progress ring behavior. * Update progresring backwards behavior * move pager resources under strings/en-us folder (#3593) * make footer menu items public (#3519) * update progress ring idl (#3599) * TabView: Fix newly-added items not respecting TabWidthMode [compact] when using an ItemsSource collection (#3118) * Fix the following issues when populating the TabView via its ItemsSource API: * crash when clearing the ItemsSource * TabWidthMode [compact] being ignored in XAML Markup and for newly-added items * small comment improvement * Added two API tests and modified existing test. * Unrelated code which was commented out is run again. * Add API test. * Simplified API test. * Merge API tests. * Add API contract checks for corner radius. * Ensure that listview selected index is not outside of the item range. * Update TabView.cpp Co-authored-by: Ranjesh <[email protected]> * Switch to using ThemeResource for icon in InfoBar (#3603) * Allow winui to detect if it's in CBS package (#3520) * build cbs * Revert "build cbs" This reverts commit 24b6812. * cbs: * Update dev/dll/SharedHelpers.cpp Co-authored-by: Jevan Saks <[email protected]> * Update dev/dll/XamlControlsResources.cpp Co-authored-by: Jevan Saks <[email protected]> * remove check for old platform and add assert * make pipeline build cbs resources.pri and manifest * Update dev/dll/XamlControlsResources.cpp * Update dev/dll/XamlControlsResources.cpp * fail fast * Update dev/dll/XamlControlsResources.cpp * fix package name when generate CBSManifest Co-authored-by: Jevan Saks <[email protected]> * Doc/roadmap updates (#3618) * Updating ordering * Updating feature roadmap * More updates to feature roadmap, roadmap graphic * Update bug_report.md (#3622) * Fix readme to mention Preview 3 instead of P2 (#3621) * Update NavigationView pane scrolling behavior (#3602) * Add initial layout updating, add test page * Add first interaction tests * Fix behavior, add scrolling behavior * CR feedback * Add hacky workaround for weird sizing behavior * Update layout, add separator * Fix updating behavior * Remove hacky workaround, fix test * Add fault tolerance to tests * Update verification files * Change Preview 2 to Preview 3 (#3626) * Update preview_upgrade_instructions.md (#3636) * TeachingTip: Fix background for light-dismissable tip (#3440) * Add missing visual state setters. * Extend API test. * update loc strings (#3650) * File Pipeline build break: Update Nuget from 5.2 to 5.8 (#3664) * Fixing an issue where we needed a FileWrites to avoid file deletion. (#3661) * Remove explicit sizes of InfoBar (#3653) * Remove explicit sizes of InfoBar * Set minheight for centering * Switch to lightweight styling resources * Update CommandBarFlyout closing animation to include button moving (#3594) * Update more-button animation behavior * Fix background issue * CR feedback * update intellisense file (#3651) * Update AcrylicBrushes and add new AcrylicBrushes (#3498) * Add new brushes, update CommandbarFlyout and NavigationView to use new brushes * Update brushes * Update brush references * Update project file * Update navigationview resources * Hacky workaround XAML compiler bug * Add check * Add comment * Fix typo * Add ImageIcon (#3629) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Fix Innerloop Solution (#3697) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Add preprocessor declaration around imageIconSource code in MakeIconElementFrom * Update InfoBarPanel API names (#3704) * Update API names * Remove grid.columns * Adding PipsPager (#3592) * PipsControl initial structure * PipsControl update file structure * Add boilerplate code * Add styles and update logic * Remove Grid inside the PipsControl * some layout fixes * Update common styles * Fix nav buttons visibility logic * Update themeresources and fix infinite scrolling * Clean up the code * Remove InneLoopAreasProps from PR * Add automation * Update resources file * Fix button visibility for automation * Fix navigaiton buttons disappearing bug * Update .idl file and add style as properties * Add handlers for button visibility changes * Add style handlers and update accessibility * Add basic test with flipview * Fix update of max number of pages * Fix maxdisplayedpages onchange handler and address small PR issues * remove commented code * Update Naming * Fix naming and fix pointer hover event * Update Tests and leave some comments * Update naming and tests * Fix sv change size and override virtual methods * Address PR comments * Address PR issues * Fix button not showing up on initial launch * Clean up the code * Update API tests * Partially Update Tests * Fix spacing * Update Strings * Attempt to fix tests * Attempt to fix tests * Fall back to manual scroll if fresh API is not available * Move API check to SharedHelpers * Fix naming Co-authored-by: Ranjesh Jaganathan <[email protected]> * fix tests * ImageIcon test fix Co-authored-by: Keith Mahoney <[email protected]> Co-authored-by: Stephen L Peters <[email protected]> Co-authored-by: Marcel Wagner <[email protected]> Co-authored-by: Felix-Dev <[email protected]> Co-authored-by: Tony Xia <[email protected]> Co-authored-by: EJ <[email protected]> Co-authored-by: T Paine <[email protected]> Co-authored-by: Jevan Saks <[email protected]> Co-authored-by: Canhua Li <[email protected]> Co-authored-by: Ana Wishnoff <[email protected]> Co-authored-by: Morten Nielsen <[email protected]> Co-authored-by: Thomas Claudius Huber <[email protected]> Co-authored-by: Luke Longley <[email protected]> Co-authored-by: Vsevolod <[email protected]>

MartinZikmund · 2021-06-19T13:10:22Z

@StephenLPeters Can you help me understand how does the "template" for the ImageIcon get there? I see the Style is empty but the code does look for Grid and Image elements in the visual tree, and I am unable to figure out how these are materialized 🤔

marcelwgn · 2021-06-19T15:47:30Z

@MartinZikmund I think since we are inheriting from IconElement, there are certain things that are being constructed from code behind. For example, the AnimatedIconSource also constructs the visuals from code behind instead of relying on the template.

Add ImageIcon

dadefd6

ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 18, 2020

ranjeshj added area-Icon area-Images Images, SVG team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Nov 18, 2020

ranjeshj requested review from jevansaks, MarissaMatt and MikeHillberg November 18, 2020 12:53

jevansaks reviewed Nov 18, 2020

View reviewed changes

jevansaks approved these changes Nov 18, 2020

View reviewed changes

ranjeshj approved these changes Nov 20, 2020

View reviewed changes

StephenLPeters added 2 commits November 20, 2020 12:09

Respond to feedback and use an svg image with an MIT license.

9aee5c7

Merge remote-tracking branch 'origin/master' into user/stpete/ImageIcon

1032e92

ranjeshj reviewed Nov 21, 2020

View reviewed changes

dev/ImageIcon/APITests/ImageIconTests.cs Outdated Show resolved Hide resolved

Fix broken test

43137ce

Platform check the IsLoaded check which was introduced in RS5

684d864

ranjeshj merged commit 513ed82 into master Nov 24, 2020

ranjeshj deleted the user/stpete/ImageIcon branch November 24, 2020 23:15

ShankarBUS mentioned this pull request Jan 5, 2021

Feature Request: Port ImageIcon and ImageIconSource from WinUI Kinnara/ModernWpf#248

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ImageIcon #3629

Add ImageIcon #3629

StephenLPeters commented Nov 18, 2020 •

edited by ranjeshj

Loading

StephenLPeters commented Nov 18, 2020

azure-pipelines bot commented Nov 18, 2020

ranjeshj commented Nov 18, 2020

jevansaks Nov 18, 2020

StephenLPeters Nov 18, 2020

jevansaks Nov 18, 2020

StephenLPeters Nov 18, 2020

jevansaks Nov 18, 2020

StephenLPeters Nov 18, 2020

ranjeshj Nov 20, 2020

jevansaks Nov 18, 2020

jevansaks left a comment

StephenLPeters commented Nov 20, 2020

azure-pipelines bot commented Nov 20, 2020

StephenLPeters commented Nov 24, 2020

azure-pipelines bot commented Nov 24, 2020

StephenLPeters commented Nov 24, 2020

azure-pipelines bot commented Nov 24, 2020

mdtauk commented Nov 24, 2020

jevansaks commented Nov 24, 2020

mdtauk commented Nov 24, 2020 •

edited

Loading

MartinZikmund commented Jun 19, 2021

marcelwgn commented Jun 19, 2021

		ImageIconSource();

		Windows.UI.Xaml.Media.ImageSource ImageSource{ get; set; };

Add ImageIcon #3629

Add ImageIcon #3629

Conversation

StephenLPeters commented Nov 18, 2020 • edited by ranjeshj Loading

StephenLPeters commented Nov 18, 2020

azure-pipelines bot commented Nov 18, 2020

ranjeshj commented Nov 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jevansaks left a comment

Choose a reason for hiding this comment

StephenLPeters commented Nov 20, 2020

azure-pipelines bot commented Nov 20, 2020

StephenLPeters commented Nov 24, 2020

azure-pipelines bot commented Nov 24, 2020

StephenLPeters commented Nov 24, 2020

azure-pipelines bot commented Nov 24, 2020

mdtauk commented Nov 24, 2020

jevansaks commented Nov 24, 2020

mdtauk commented Nov 24, 2020 • edited Loading

MartinZikmund commented Jun 19, 2021

marcelwgn commented Jun 19, 2021

StephenLPeters commented Nov 18, 2020 •

edited by ranjeshj

Loading

mdtauk commented Nov 24, 2020 •

edited

Loading