UniformGridLayout (FlowLayout): Fix issue with scrolling up creating gaps in layout #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
StephenLPeters
added
area-ItemsRepeater
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
reviewed
Mar 9, 2021
|
|
||
| <!-- The DataTemplate used: CircularTemplate--> | ||
|
|
||
| <DataTemplate x:Key="CircularTemplate" x:DataType="x:String"> |
ranjeshj
reviewed
Mar 9, 2021
| { | ||
| this.InitializeComponent(); | ||
| for (int i = 0; i < 40; ++i) | ||
| collection.Add(i.ToString()); |
There was a problem hiding this comment.
could be simplified by just setting it in line 17.. using Enumerable.Range(0, 40)
ranjeshj
reviewed
Mar 9, 2021
| IsVerticalScrollChainingEnabled="False" | ||
| AutomationProperties.Name="RepeaterScrollViewer" | ||
| MaxHeight="500"> | ||
| <controls:ItemsRepeater x:Name="UniformGridRepeater" |
There was a problem hiding this comment.
curious if this would be easier to see if you set vertical cache to 0
ranjeshj
approved these changes
Mar 9, 2021
|
@ranjeshj Would you like me to address your comments or rather merge as is? |
Yes please. They were minor feedback, so if you can resolve them, that would be great and I don't expect those to cause new failures. |
|
Added them now. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carldebilly
added a commit
to unoplatform/uno
that referenced
this pull request
Apr 9, 2021
…ghm with operating in virtual. This is a backport of microsoft/microsoft-ui-xaml#3393 into Uno
carldebilly
added a commit
to unoplatform/uno
that referenced
this pull request
Apr 12, 2021
…ghm with operating in virtual. This is a backport of microsoft/microsoft-ui-xaml#3393 into Uno
carldebilly
added a commit
to unoplatform/uno
that referenced
this pull request
Apr 26, 2021
…ghm with operating in virtual. This is a backport of microsoft/microsoft-ui-xaml#3393 into Uno
carldebilly
added a commit
to unoplatform/uno
that referenced
this pull request
Apr 27, 2021
…ghm with operating in virtual. This is a backport of microsoft/microsoft-ui-xaml#3393 into Uno
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Nov 13, 2023
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue was that the Generate(Backward) logic was faulty. When trying to generate the previous line, the next item was placed entirely to the right, however when having multiple items per row, this is not correct. That's why the UniformGridLayout ended up with single column content when scrolling up. The updated behavior is to take the last extent into account to place the last item of the previous row.
Motivation and Context
Closes #1887
How Has This Been Tested?
Add new interaction test.
Screenshots (if appropriate):