Add check for UIObject circles resulting in infinite loops (#3516)

* Add check for UIObject circles resulting in infinite loops * Update check to break after encountering item 10 times in a row * Update logic
microsoft · Mar 31, 2021 · d7c672d · d7c672d
1 parent d5e6a00
commit d7c672d
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/test/testinfra/MUXTestInfra/Common/FindElement.cs b/test/testinfra/MUXTestInfra/Common/FindElement.cs
@@ -309,8 +309,25 @@ public static void Refresh()
             Wait.ForIdle(findElementsIfNull: false); // false because otherwise Wait.ForIdle() might call Refresh(), and then we have an infinite loop.
 
             UIObject window = TestEnvironment.Application.ApplicationFrameWindow ?? TestEnvironment.Application.CoreWindow;
+            int dupeCount = 0;
+            UIObject lastItem = null;
             foreach (UIObject obj in window.Descendants)
             {
+                // Check if we encounter the same element twice in a row indicating a loop in the UIObjects.
+                if(lastItem == obj)
+                {
+                    dupeCount++;
+                }
+                else
+                {
+                    dupeCount = 0;
+                    lastItem = obj;
+                }
+                // Only break if an item was encountered more then 10 times.
+                if(dupeCount >= 10)
+                {
+                    break;
+                }
                 if (!string.IsNullOrWhiteSpace(obj.AutomationId) && !objectFromIdCache.ContainsKey(obj.AutomationId))
                 {
                     objectFromIdCache.Add(obj.AutomationId, obj);