CommandBarFlyoutCommandBar should honor the "Show animations in Windo…

…ws" setting on open and close (#5096)

XAML's VisualStateManager handles the honoring of most animations, but in the case of CommandBarFlyout, we have open and close animations that we play manually external to the VisualStateManager. In that case, we should check for animations being enabled before reporting that they exist and having them be played.

This is a purely visual change that relies on a system setting being set that we don't have test infrastructure for, so I haven't added any automated testing here, but I manually verified that the open/close animation no longer plays when that setting is turned off, and then resumes playing when it's turned back on.

dev/CommandBarFlyout/CommandBarFlyoutCommandBar.cpp

@@ -426,7 +426,7 @@ void CommandBarFlyoutCommandBar::DetachEventHandlers()
 
 bool CommandBarFlyoutCommandBar::HasOpenAnimation()
 {
-    return static_cast<bool>(m_openingStoryboard);
+    return static_cast<bool>(m_openingStoryboard) && SharedHelpers::IsAnimationsEnabled();
 }
 
 void CommandBarFlyoutCommandBar::PlayOpenAnimation()
@@ -442,7 +442,7 @@ void CommandBarFlyoutCommandBar::PlayOpenAnimation()
 
 bool CommandBarFlyoutCommandBar::HasCloseAnimation()
 {
-    return static_cast<bool>(m_closingStoryboard);
+    return static_cast<bool>(m_closingStoryboard) && SharedHelpers::IsAnimationsEnabled();
 }
 
 void CommandBarFlyoutCommandBar::PlayCloseAnimation(