Fix CommandBarFlyout not having shadows (#5234)

* Fix CommandBarFlyout not having shadows since drop shadows now require translation to be set. * Fix down level build break.
microsoft · Jun 22, 2021 · 3844707 · 3844707
1 parent 4d9d005
commit 3844707
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/dev/CommandBarFlyout/CommandBarFlyout.cpp b/dev/CommandBarFlyout/CommandBarFlyout.cpp
@@ -282,6 +282,10 @@ winrt::Control CommandBarFlyout::CreatePresenter()
     presenter.BorderThickness(winrt::ThicknessHelper::FromUniformLength(0));
     presenter.Padding(winrt::ThicknessHelper::FromUniformLength(0));
     presenter.Content(*commandBar);
+    if (SharedHelpers::IsRS5OrHigher())
+    {
+        presenter.Translation({ 0.0f, 0.0f, 32.0f });
+    }
 
     // Disable the default shadow, as we'll be providing our own shadow.
     if (winrt::IFlyoutPresenter2 presenter2 = presenter)

diff --git a/dev/CommandBarFlyout/CommandBarFlyout_themeresources.xaml b/dev/CommandBarFlyout/CommandBarFlyout_themeresources.xaml
@@ -1296,7 +1296,8 @@
                                     <Grid
                                         x:Name="OuterOverflowContentRootV2"
                                         RequestedTheme="{TemplateBinding ActualTheme}"
-                                        Width="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=FlyoutTemplateSettings.ExpandedWidth}">
+                                        Width="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=FlyoutTemplateSettings.ExpandedWidth}"
+                                        contract7Present:Translation="0,0,32">
                                         <Grid.RenderTransform>
                                             <TranslateTransform
                                                 x:Name="OverflowContentRootTransform"