Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preselect field to CompletionItem #515

Closed
wants to merge 1 commit into from
Closed

Add preselect field to CompletionItem #515

wants to merge 1 commit into from

Conversation

MikhailArkhipov
Copy link

@MikhailArkhipov MikhailArkhipov commented Jul 5, 2018

Fixes #515

VS Code 1.25 adds new preselect field to the CompletionItem. The field allows completion providers to specify which item should be initially selected in the completion list.

By default clients usually select first or last used items, which is limiting. A completion provider may choose to select different item based on other conditions, such as current code editor context, probability of use of certain items, and so on.

This request is to add equivalent field to the CompletionItem structure therefore allowing use of preselection in VS Code from language servers as it is possible from the regular completion provider.

The respective Node LS issue is microsoft/vscode-languageserver-node#371

@dbaeumer
Copy link
Member

dbaeumer commented Jul 6, 2018

A first implementation can be found here

https://github.com/Microsoft/vscode-languageserver-node/tree/dbaeumer/371

@dbaeumer
Copy link
Member

Closing. Got added to 3.9.0.

@dbaeumer dbaeumer closed this Jul 10, 2018
@MikhailArkhipov
Copy link
Author

@dbaeumer - do we need to update specification to reflect the change?

@dbaeumer
Copy link
Member

I did update the specification put forgot to push :-(

@aeschli aeschli added this to the July 2018 milestone Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants