-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support llmGenerated
property on CodeAction
#2020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be more flexible if this were just a source
hint, which can be an arbitrary string, or an enum+string for some well defined code action sources where llm
is one of them?
E.g. if LLM gets replaced by some newer tech, there wouldn't be need to introduce a xyGenerated
property.
Then this also wouldn't need a client capability (because if the client shows a fancy icon or something shouldn't matter for servers)
Thanks for the feedback, I've updated to use |
@StellaHuang95 we should use the same wording tweaks as proposed in microsoft/vscode-languageserver-node#1557 |
af4da5c
to
7f58e76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add a client capability indicating that the client supports tags. If should go somewhere here https://github.com/microsoft/language-server-protocol/blob/gh-pages/_specifications/lsp/3.18/language/codeAction.md#L110 and should be named tagSupport
. You can use this https://github.com/microsoft/language-server-protocol/blob/gh-pages/_specifications/lsp/3.18/language/completion.md#L74 as a blueprint.
Sorry, forgot about that.
Addresses microsoft/vscode-languageserver-node#1555
llmGeneratedSupport
toCodeActionClientCapabilities
.llmGenerated
toCodeAction
.proposed
.