Set shell: true when spawning npm commands #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
changed the title
|
Hi, can you check that this fix works when the NPM is in a folder that has whitespaces in its name (e.g. "Program Files) ? |
ecraig12345
changed the title
I got rid of the manual npm command resolution logic, so it should be fine with spaces now. |
kenotron
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a Node security fix (see nodejs/node@69ffc6d50d, nodejs/node#52554) it's now necessary to pass
shell: trueto spawnnpmon Windows. I added a test and re-enabled Windows builds to verify that this still works.This will likely cause some perf degradation due to the extra step of spawning a shell, but it seems there's not really a way around that for Windows now.
Also removed the custom logic to resolve the npm client and the
@lage-run/find-npm-clientpackage, since that ought to be handled in the shell based on the PATH.Fixes #733