Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command/Argument Preview Mechanism #152

Merged
merged 6 commits into from
May 22, 2019
Merged

Command/Argument Preview Mechanism #152

merged 6 commits into from
May 22, 2019

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented May 21, 2019

Allows command authors to designate that commands, command groups, and arguments are in a preview state, similar to the existing deprecation mechanism.

@tjprescott tjprescott added this to the Sprint 62 milestone May 21, 2019
@tjprescott tjprescott requested a review from marstr May 21, 2019 00:04
@marstr
Copy link
Member

marstr commented May 21, 2019

Just out of curiosity, how easy would it be to tack on a hidden option? I'd love to have self-test stop telling me that it was going to be deleted soon if it's easy.

Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers, one nit, one question

knack/invocation.py Outdated Show resolved Hide resolved
knack/preview.py Show resolved Hide resolved
@tjprescott
Copy link
Member Author

@marstr I cleaned up the code to let develops simply use is_preview=True.

@tjprescott tjprescott closed this May 22, 2019
@tjprescott tjprescott reopened this May 22, 2019
@tjprescott
Copy link
Member Author

Not sure why TravisCI isn't linked to GitHub now, but the build passed so I will merge.

@tjprescott tjprescott merged commit 7993fa2 into microsoft:master May 22, 2019
@tjprescott tjprescott deleted the PreviewMechanism branch May 22, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants