Do not convert first char to upper on type names during code model construction #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Jul 6, 2023
|
I'm looking into it. It seems the writers in some places inconsistently handle type names. I've located the issue with Python, looking into PHP now. |
microsoft-github-policy-service
bot
added
Needs: Attention 👋
and removed
Needs: Author Feedback
labels
|
@baywet I've pushed a fix for the Python code generation, but I've got the feeling that the PHP errors are not related to this change. I generated PHP code for the Twitter spec with and without this change, and only got 1 totally unrelated difference. It seems the code generation for the Twitter spec is unstable due to problems with discriminators. |
papegaaij
force-pushed
the
fix-type-name-uppercase
branch
from
bc3697a
to
386b07f
Compare
|
yes from what @Ndiritu was telling me the PHP issues are a side effect of the PR I've just reverted. Do you mind rebasing for sanity please? |
papegaaij
force-pushed
the
fix-type-name-uppercase
branch
from
386b07f
to
5fbe7f5
Compare
This was referenced Jul 7, 2023
papegaaij
force-pushed
the
fix-type-name-uppercase
branch
from
5fbe7f5
to
b28cdfe
Compare
…nstruction Types are sometimes created with an upper case type name and sometimes with a lower case type name. This has no functional effect on the resulting code, because the writers will do this, but the converted name can end up in the comment. The comment should follow the spec and should be stable as much as possible.
Both import and location of usage must use toFirstCharacterUpperCase() to match.
baywet
force-pushed
the
fix-type-name-uppercase
branch
from
b28cdfe
to
f430352
Compare
baywet
previously approved these changes
Jul 10, 2023
baywet
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types are sometimes created with an upper case type name and sometimes with a lower case type name. This has no functional effect on the resulting code, because the writers will do this, but the converted name can end up in the comment. The comment should follow the spec and should be stable as much as possible.
This pull request fixes spurious changes like in
models/group.goin this PR https://github.com/microsoftgraph/msgraph-sdk-go/pull/523/files .