Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby support for serialization registration #478

Closed
6 tasks done
baywet opened this issue Aug 12, 2021 · 0 comments · Fixed by #2093
Closed
6 tasks done

ruby support for serialization registration #478

baywet opened this issue Aug 12, 2021 · 0 comments · Fixed by #2093
Assignees
Labels
enhancement New feature or request fixed Ruby
Milestone

Comments

@baywet
Copy link
Member

baywet commented Aug 12, 2021

The ruby abstractions and generation process doesn't support registering the serialization providers. This pushes an additional requirement on consumers to manually register those for the different serialization formats they want to support.

TODO:

  • update the Ruby CodeMethodWriter (ApiClientConstructor) so it generates the calls to the registration by reading the SerializerModules and DeserializerModules properties on the code method.
  • Add a static class with the registration methods, see an example in Java
  • Add default instances on the registries for parse node and serialization writer
  • Add calls to the ReplaceDefaultSerializationModules, ReplaceDefaultDeserializationModules, and AddSerializationModulesImport methods in the Ruby refiner (see examples in the other language)
  • Update the table of parameters with the default values for Ruby in the main readme
  • Update the HttpCore service to leverage the default instances of the registries when no value is passed as parameter
    AB#10651
@baywet baywet added enhancement New feature or request help wanted Issue caused by core project dependency modules or library Ruby labels Aug 12, 2021
@baywet baywet added this to the GA milestone Aug 12, 2021
@baywet baywet self-assigned this Dec 19, 2022
@baywet baywet added fixed and removed help wanted Issue caused by core project dependency modules or library hacktoberfest labels Dec 19, 2022
@baywet baywet linked a pull request Dec 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Ruby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants