Return ReadSeekCloser from compression middleware #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary as retry logic requires the ability to seek the request body before retrying or the body ends up as empty.
andrueastman
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Thanks for this @meain
Any chance you could also add a Changelog entry for this at https://github.com/microsoft/kiota-http-go/blob/main/CHANGELOG.md
baywet
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Thanks for the contribution!
As Andrew mentioned, can you update the changelog please?
As well as
kiota-http-go/user_agent_handler.go
Line 45 in 59b1f5f
(bump the patch version, today's date for both)
Lastly, I'll comment on the original issue to clarify something about the order.
|
@andrueastman @baywet updated changelog and bumped version. |
meain
force-pushed
the
compression-seek
branch
from
dea8310
to
856d46e
Compare
|
Given the possible ordering issue, do we want to look int that in this PR? |
baywet
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary as retry logic requires the ability to seek the request body before retrying or the body ends up as empty.
Fixes #183 as long as compression middleware is before retry logic.