Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compression issue if content-range header is present #174

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Fixing compression issue if content-range header is present #174

merged 8 commits into from
Jul 16, 2024

Conversation

buechele
Copy link
Contributor

  • Don't compress body if content-range header is present
  • Set content-size header if it's present in the abstract headers

This should fix this issue:
microsoftgraph/msgraph-sdk-go-core#295

@buechele buechele requested a review from a team as a code owner July 16, 2024 07:58
@buechele
Copy link
Contributor Author

buechele commented Jul 16, 2024

@microsoft-github-policy-service agree

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @buechele

Any chance you could add a changelo entry as well at https://github.com/microsoft/kiota-http-go/blob/main/CHANGELOG.md with todays date?

Otherwise, this looks good to me.

@buechele
Copy link
Contributor Author

@andrueastman I updated the CHANGELOG. I hope I did this as it is intended to happen.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting this!
One comment to solve here and we should be good to go

compression_handler.go Outdated Show resolved Hide resolved
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@baywet baywet enabled auto-merge July 16, 2024 11:02
@baywet baywet merged commit ab72ea5 into microsoft:main Jul 16, 2024
7 checks passed
@buechele buechele deleted the compression-content-range branch July 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants