Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add response headers and status code to returned error #125

Merged
merged 3 commits into from
Nov 22, 2023
Merged

add response headers and status code to returned error #125

merged 3 commits into from
Nov 22, 2023

Conversation

NerdJeremia
Copy link
Contributor

@NerdJeremia NerdJeremia commented Nov 22, 2023 •
edited by baywet
Loading

fixes #110

baywet
baywet requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. A minor recommendation and we should be good to go.

nethttp_request_adapter.go Show resolved Hide resolved
baywet
baywet approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet merged commit 390840a into microsoft:main Nov 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@peombwa peombwa Awaiting requested review from peombwa

@calebkiage calebkiage Awaiting requested review from calebkiage

@rkodev rkodev Awaiting requested review from rkodev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response headers are not added to returned error
2 participants
@NerdJeremia @baywet