now using skl>=1.5.0

microsoft · May 30, 2024 · 2d3d402 · 2d3d402
1 parent d463516
commit 2d3d402
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml
@@ -54,12 +54,6 @@ jobs:
     - name: Install basic dependencies
       run: |
         python -m pip install -e .[tests] -f https://download.pytorch.org/whl/torch_stable.html
-    - name: Test with older SKLearn on Linux with py3.9 to check backward compatibility
-      if: ${{ matrix.python-version == '3.9' && startsWith(matrix.os, 'ubuntu') == true }}
-      run: python -m pip install scikit-learn==1.2.1
-    - name: Pin SKLearn<1.5.0 on not Linux with py3.9
-      if: ${{ !(matrix.python-version == '3.9' && startsWith(matrix.os, 'ubuntu') == true) }}
-      run: python -m pip install "scikit-learn<1.5.0"
     - name: Run basic tests without extra
       run: pytest
     - name: Coverage on basic tests without extra

diff --git a/setup.py b/setup.py
@@ -23,7 +23,7 @@
     "numpy>=1.15",
     "onnxconverter-common>=1.6.0",
     "scipy",
-    "scikit-learn",
+    "scikit-learn>=1.5.0",
     "torch>1.7.0",
     "psutil",
     "dill",