Use "hcsschema" in internal/hcs
#1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `hcsschema.ProcessModifyRequest` (and associated structs) in `internal/hcs/process` when making modify requests and getting process properties. Update `hcschema` structs to match documentation (swagger seems to default to `int32` for generated fields regardless of the type specified in the documentation). Signed-off-by: Hamza El-Saawy <[email protected]>
anmaxvl
approved these changes
Sep 25, 2023
katiewasnothere
approved these changes
Oct 4, 2023
darracott
pushed a commit
to KenGordon/hcsshim
that referenced
this pull request
Oct 30, 2023
Use `hcsschema.ProcessModifyRequest` (and associated structs) in `internal/hcs/process` when making modify requests and getting process properties. Update `hcschema` structs to match documentation (swagger seems to default to `int32` for generated fields regardless of the type specified in the documentation). Signed-off-by: Hamza El-Saawy <[email protected]>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Use `hcsschema.ProcessModifyRequest` (and associated structs) in `internal/hcs/process` when making modify requests and getting process properties. Update `hcschema` structs to match documentation (swagger seems to default to `int32` for generated fields regardless of the type specified in the documentation). Signed-off-by: Hamza El-Saawy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
hcsschema.ProcessModifyRequest(and associated structs) ininternal/hcs/processwhen making modify requests and getting process properties.Update
hcschemastructs to match documentation (swagger seems to default toint32for generated fields regardless of the type specified in the documentation).