Pin go version for linter to 1.17.x #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the tooling golangci-lint uses doesn't fully support 1.18 yet resulting in a bunch of hard to decode errors. We were using ^1.17.0 as our version listed so we ended up resolving to 1.18 a couple of days ago and finally ran into this. v1.45.0 of golangci-lint has a workaround for this which is disabling some of the problematic linters, but these are some of our most used. This seems like a sane fix for now until the kinks are worked out and things are working on 1.18. Signed-off-by: Daniel Canter <[email protected]>
helsaawy
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tooling golangci-lint uses doesn't fully support 1.18 yet resulting in a bunch of hard to decode errors. We were using ^1.17.0 as our version listed so we ended up resolving to 1.18 a couple of days ago and finally ran into this. v1.45.0 of golangci-lint has a workaround for this which is disabling some of the problematic linters, but these are some of our most used. This seems like a sane fix for now until the kinks are ironed out and things are working on 1.18.