Fix typo in error message #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to cd to test and run |
Signed-off-by: Sean T. Allen <[email protected]>
|
@dcantah - Is there a spellcheck linter? I make mistakes like this all the time, seems like since its public code anyways when its checked in a public spellchecker should be fine to run on it right? |
|
It has been my experience that spellcheckers on code become a nightmare. |
|
Yea, I'm not sure I'd have high hopes for a spellcheck linter but one does exist that's disabled by default for golangci-lint https://golangci-lint.run/usage/linters/#misspell |
|
Haha. Its no so bad right... Win32, IOCP, IOCTL, containerd, fuse, <- Hey that one would work... |
|
I wonder if it would complain about containerd needing to be containers* |
|
@dcantah CI passed. |
anmaxvl
added a commit
to anmaxvl/hcsshim
that referenced
this pull request
Apr 22, 2022
…)" This reverts commit 2028de8. During local testing a gcs with an older version of security policy was used when doing the fix: microsoft#1322. As we can see, the quotations weren't there. However, later a PR was merged, which added them: microsoft#1311 Signed-off-by: Maksim An <[email protected]>
anmaxvl
added a commit
that referenced
this pull request
Apr 22, 2022
This reverts commit 2028de8. During local testing a gcs with an older version of security policy was used when doing the fix: #1322. As we can see, the quotations weren't there. However, later a PR was merged, which added them: #1311 Signed-off-by: Maksim An <[email protected]>
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean T. Allen [email protected]