-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support udt for rows.ColumnTypes #214
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 74.79% 74.87% +0.07%
==========================================
Files 32 32
Lines 6379 6387 +8
==========================================
+ Hits 4771 4782 +11
+ Misses 1325 1323 -2
+ Partials 283 282 -1 ☔ View full report in Codecov by Sentry. |
Thanks a lot for opening this PR i have opened another one (#216) that tries to tackle the same issues. I have added some additional checks to ensure that the only type of UDT accepted are geometry, geography or hierarchyid since those are the ones tested. I think it would be better for us to join effort in trying to get that one approved. |
When querying data of udt type for geometry , calling rows.ColumnTypes will panic.
Types add related branch logic
unit test