Skip to content

Commit

Permalink
path-walk: improve path-walk speed with many tags (#695)
Browse files Browse the repository at this point in the history
In the presence of many tags, the use of oid_array_lookup() can become
extremely slow. We should rely upon the SEEN bit instead.

This affects the tag-peeling walk as well as the switch statement for
adding the peeled object to the correct oid_array.

----

I found this while testing the 2.47.0.vfs.0.0 pre-release against a repo
with many annotated tags.
  • Loading branch information
dscho authored Oct 9, 2024
2 parents 26ff51d + 134a50d commit dda73ee
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions path-walk.c
Original file line number Diff line number Diff line change
Expand Up @@ -299,26 +299,28 @@ int walk_objects_by_path(struct path_walk_info *info)
if (obj->type == OBJ_COMMIT || obj->flags & SEEN)
continue;

obj->flags |= SEEN;

while (obj->type == OBJ_TAG) {
struct tag *tag = lookup_tag(info->revs->repo,
&obj->oid);
if (oid_array_lookup(&tags, &obj->oid) < 0)
if (!(obj->flags & SEEN)) {
obj->flags |= SEEN;
oid_array_append(&tags, &obj->oid);
}
obj = tag->tagged;
}

if ((obj->flags & SEEN))
continue;
obj->flags |= SEEN;

switch (obj->type) {
case OBJ_TREE:
if (info->trees &&
oid_array_lookup(&root_tree_list->oids, &obj->oid) < 0)
if (info->trees)
oid_array_append(&root_tree_list->oids, &obj->oid);
break;

case OBJ_BLOB:
if (info->blobs &&
oid_array_lookup(&tagged_blob_list, &obj->oid) < 0)
if (info->blobs)
oid_array_append(&tagged_blob_list, &obj->oid);
break;

Expand Down

0 comments on commit dda73ee

Please sign in to comment.