New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AOF Replay using a Background Task at the Replica #783

Merged

vazois merged 20 commits into microsoft:main from vazois:vazois/aof-background-process

Nov 21, 2024

Contributor

vazois commented Nov 7, 2024 •

edited

Loading

This PR separates AOF enqueue operation from replay. It contains the following

Implementation of an IBulkLogConsumer that performs the AOF replay at the replica side.
Adds throttling of enqueue operations when AOF replay lags beyond a specific amount (i.e. throttle if TailAddress - ReplicationOffset >ReplicationMaxLag)
Ensure re-initialization due to address skipping happens safely while replay consumer is reading from the log.

PS: Fixed a bug related to LRANGE which was incorrectly calling RMWObjectStoreOperationWithOutput instead of ReadObjectStoreOperationWithOutput

vazois force-pushed the vazois/aof-background-process branch 2 times, most recently from 74ba15b to e0f28f1 Compare

November 8, 2024 19:50

vazois marked this pull request as ready for review

November 8, 2024 20:02

vazois requested a review from badrishc

November 8, 2024 20:02

vazois force-pushed the vazois/aof-background-process branch from e0f28f1 to 6880d53 Compare

November 8, 2024 20:11

TalZaccai self-requested a review

November 12, 2024 19:13

badrishc reviewed

View reviewed changes

libs/storage/Tsavorite/cs/src/core/TsavoriteLog/TsavoriteLogIterator.cs Outdated Show resolved Hide resolved

badrishc reviewed

View reviewed changes

libs/cluster/Server/Replication/PrimaryOps/AofSyncTaskInfo.cs Show resolved Hide resolved

badrishc reviewed

View reviewed changes

libs/cluster/Server/Replication/ReplicaOps/ReplicationReplicaAofSync.cs Outdated Show resolved Hide resolved

badrishc reviewed

View reviewed changes

libs/host/Configuration/Options.cs Outdated Show resolved Hide resolved

badrishc reviewed

View reviewed changes

libs/server/Servers/GarnetServerOptions.cs Outdated Show resolved Hide resolved

badrishc reviewed

View reviewed changes

libs/host/Configuration/Options.cs Outdated Show resolved Hide resolved

vazois force-pushed the vazois/aof-background-process branch 8 times, most recently from 04f9ca5 to 5f0be76 Compare

November 15, 2024 22:21

badrishc approved these changes

View reviewed changes

badrishc reviewed

View reviewed changes

libs/cluster/Server/Replication/ReplicaOps/ReplicaReplayTask.cs Outdated Show resolved Hide resolved

badrishc reviewed

View reviewed changes

libs/cluster/Server/Replication/ReplicaOps/ReplicationReplicaAofSync.cs Outdated Show resolved Hide resolved

badrishc requested changes

View reviewed changes

Contributor

badrishc left a comment

see comments

badrishc reviewed

View reviewed changes

libs/cluster/Server/Replication/ReplicaOps/ReplicationReplicaAofSync.cs Outdated Show resolved Hide resolved

vazois force-pushed the vazois/aof-background-process branch 4 times, most recently from a078f1d to b004fc8 Compare

November 18, 2024 23:29

vazois requested a review from badrishc

November 19, 2024 19:48

badrishc approved these changes

View reviewed changes

vazois added 20 commits

November 21, 2024 11:17


          remove unused code

bdf97b8

nit

ddd89e7


          cleanup replication tests

1b65366


          expose replica max lag parameter

2bd6302


          add guarded initialization API for TsavoriteLog to avoid disrupting i…

e94bdf3

…terator consumer operations when skipping addresses at replica


          background replay consume implementation

626b7b2


          rename replay max lag parameter and added stats info

2f7f7da


          update aof stream checks


          fix LRANGE bug

0650f8b


          ensure replicaof resets replay iterator

72a1c76


          add async replay tests

64b3905


          remap ReplicationOffsetMaxLag parameter to make infinite lag default

09c123b


          streamline spinwait for initialization using ProtectAndDrain

c86a971


          add check to detect AOF divergence at the replica

ed0ca7f


          update unit tests for ClusterReplayAsync

9b7a739


          delete stale comment

5adbffb


          pageSizeBits instance variable for use with process AOF stream

bd63c44


          update sanity check

07dff41


          add comment for sanity check

aed1b7d


          release new version

504cb68

vazois force-pushed the vazois/aof-background-process branch from b004fc8 to 504cb68 Compare

November 21, 2024 19:17

vazois merged commit b2856c3 into microsoft:main

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet