-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Slot Verification #709
Merged
vazois
merged 11 commits into
microsoft:main
from
vazois:vazois/slot-verification-cleanup
Oct 9, 2024
Merged
Cleanup Slot Verification #709
vazois
merged 11 commits into
microsoft:main
from
vazois:vazois/slot-verification-cleanup
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vazois
commented
Oct 9, 2024
•
edited
Loading
edited
- Refactor object commands to use cluster slot verification
- Add comments to slot verification testing
- Fix calculation of keynum for commands containing number of keys as part of the parameters
badrishc
reviewed
Oct 9, 2024
vazois
force-pushed
the
vazois/slot-verification-cleanup
branch
from
October 9, 2024 01:27
68296d8
to
d8cb0b8
Compare
3 tasks
badrishc
reviewed
Oct 9, 2024
vazois
force-pushed
the
vazois/slot-verification-cleanup
branch
from
October 9, 2024 03:25
29e1aa4
to
72cf7d8
Compare
badrishc
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.