-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Reset behavior to be more consistent with Redis #685
Merged
vazois
merged 10 commits into
microsoft:main
from
Mathos1432:users/matrembl/fix-reset-hard
Sep 26, 2024
Merged
Change Reset behavior to be more consistent with Redis #685
vazois
merged 10 commits into
microsoft:main
from
Mathos1432:users/matrembl/fix-reset-hard
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathos1432
changed the title
Fix Hard Reset is adding the other nodes to the ban list
Change Reset behavior to be more consistent with Redis
Sep 24, 2024
…ossip connections when a reset command is issued. Remove ban list
Mathos1432
force-pushed
the
users/matrembl/fix-reset-hard
branch
from
September 24, 2024 20:42
9ea8fad
to
38ee782
Compare
vazois
reviewed
Sep 25, 2024
vazois
reviewed
Sep 25, 2024
vazois
reviewed
Sep 25, 2024
…thos1432/garnet into users/matrembl/fix-reset-hard
vazois
reviewed
Sep 25, 2024
vazois
reviewed
Sep 25, 2024
vazois
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions. Please see comments.
vazois
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified by running the updated test before the fixes (failed) and after the fixes (passed)