Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Reset behavior to be more consistent with Redis #685

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

Mathos1432
Copy link
Contributor

@Mathos1432 Mathos1432 commented Sep 23, 2024

  1. In Redis RESET doesn't add the other nodes to a ban list.
  • Updated to remove the banlist entirely.
  1. Close gossip connections when a RESET comes in
  • Added a test to verify that the node isn't getting any gossips after a reset.
  1. Don't allow RESET when a node has keys in its assigned hashslots.
  • Iterate over the main store and the object store until you find a slot that has a key.

Verified by running the updated test before the fixes (failed) and after the fixes (passed)

@yrajas yrajas requested a review from vazois September 24, 2024 18:20
@Mathos1432 Mathos1432 marked this pull request as draft September 24, 2024 18:40
@Mathos1432 Mathos1432 changed the title Fix Hard Reset is adding the other nodes to the ban list Change Reset behavior to be more consistent with Redis Sep 24, 2024
…ossip connections when a reset command is issued. Remove ban list
@Mathos1432 Mathos1432 marked this pull request as ready for review September 25, 2024 14:49
Copy link
Contributor

@vazois vazois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions. Please see comments.

@vazois vazois merged commit 1218678 into microsoft:main Sep 26, 2024
15 checks passed
@Mathos1432 Mathos1432 deleted the users/matrembl/fix-reset-hard branch September 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants