Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke custom commands from custom proc/txn #597

Merged
merged 26 commits into from
Nov 22, 2024
Merged

Invoke custom commands from custom proc/txn #597

merged 26 commits into from
Nov 22, 2024

Conversation

yrajas
Copy link
Contributor

@yrajas yrajas commented Aug 16, 2024 •
edited
Loading

Adds ability to invoke custom raw string commands and object commands from within custom procedures and transactions.

  • New APIs in CustomFunctions to invoke custom commands from custom procedures and transactions
  • CustomProcedure registration updated to take in a delegate similar to custom transaction registration
  • RespServerSession reference added to CustomFunctions to enable parsing of custom commands and invoking underlying API
  • Sample custom procedure and transaction that invoke custom raw string and object commands
  • Corresponding tests.

@yrajas yrajas force-pushed the yrajas/proctocmd branch 2 times, most recently from c1391fc to f0450e4 Compare October 22, 2024 04:36
@yrajas yrajas changed the title [WIP] Invoke custom raw string cmd from custom proc/txn [WIP] Invoke custom commands from custom proc/txn Oct 22, 2024
@yrajas yrajas changed the title [WIP] Invoke custom commands from custom proc/txn Invoke custom commands from custom proc/txn Oct 22, 2024
@yrajas yrajas marked this pull request as ready for review October 22, 2024 19:54
@TalZaccai TalZaccai self-requested a review November 12, 2024 19:11
TalZaccai
TalZaccai requested changes Nov 14, 2024
View reviewed changes
libs/server/Custom/CustomCommandManagerSession.cs Outdated Show resolved Hide resolved
libs/server/Custom/CustomCommandManagerSession.cs Show resolved Hide resolved
libs/server/Custom/CustomRespCommands.cs Outdated Show resolved Hide resolved
libs/server/Custom/CustomRespCommands.cs Outdated Show resolved Hide resolved
@yrajas yrajas merged commit 08f3b68 into microsoft:main Nov 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalZaccai TalZaccai TalZaccai approved these changes

@badrishc badrishc Awaiting requested review from badrishc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yrajas @badrishc @TalZaccai