Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Encoding.ASCII.GetBytes([constant string})
calls with the newish UTF-8 string literals syntax where applicable..data
-section where possible but there's still a lot of opportunities for that.RespWriteUtils.WriteBulkString
andRespWriteUtils.WriteDirect
to takeReadOnlySpan<byte>
s instead of arraysMemory<byte>
overloads which should pretty much never be parameters in sync paths. We can just pass theMemory<byte>.Span
to the write methods instead.