Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing some deprecated components flagged when turning tslint deprecation flag to true in oufr package #7174

Merged
merged 16 commits into from
Nov 30, 2018
Merged

Removing some deprecated components flagged when turning tslint deprecation flag to true in oufr package #7174

merged 16 commits into from
Nov 30, 2018

Conversation

khmakoto
Copy link
Member

@khmakoto khmakoto commented Nov 20, 2018 •
edited by fabricteam
Loading

Pull request checklist

Description of changes

Removing some deprecated components flagged when turning tslint deprecation flag to true in oufr package.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

khmakoto added 15 commits October 22, 2018 16:22
@khmakoto
Removing some of the deprecated components flaged when turning the ts…
408542c 
…lint deprecation flag to true in the office-ui-fabric-react package.
@khmakoto
Adding corresponding change file.
9a70bf7
@khmakoto
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
9ad7683 
…c-react
@khmakoto
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
8e5a757 
…c-react
@khmakoto
Reverting changes that affected backwards compatibility because it re…
9e4a643 
…moved own deprecated usage.
@khmakoto
Adding missing deprecation reversion in BaseButton.
146d37a
@khmakoto
Removed some of the deprecated components flagged when turning the ts…
3ceb617 
…lint deprecation flag to true in the office-ui-fabric-react package.
@khmakoto
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
60563db 
…c-react into changes1
@khmakoto
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
c37197d 
…c-react into changes2
@khmakoto
Removed some of the deprecated components flagged when turning the ts…
148ea1b 
…lint deprecation flag to true in the office-ui-fabric-react package.
@khmakoto
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
3279990 
…c-react into changes3
@khmakoto
Removed some of the deprecated components flagged when turning the ts…
1283014 
…lint deprecation flag to true in the office-ui-fabric-react package.
@khmakoto
Removed some of the deprecated components flagged when turning the ts…
d3dd101 
…lint deprecation flag to true in the office-ui-fabric-react package.
@khmakoto
Fixing merge conflict.
4d59d20
@khmakoto
Updating api
4c99f87
@KevinTCoughlin
Copy link
Member

Went thru the modified files looking for out-dated ref usages, but they all seem to be updated to .current 👍

@dzearing dzearing merged commit 719443e into microsoft:master Nov 30, 2018
@khmakoto khmakoto deleted the changes4 branch November 30, 2018 19:31
@msft-github-bot
Copy link
Contributor

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy Links:

@msft-github-bot msft-github-bot mentioned this pull request Dec 3, 2018
Closed
5 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JasonGore JasonGore JasonGore approved these changes

@kenotron kenotron Awaiting requested review from kenotron

@cliffkoh cliffkoh Awaiting requested review from cliffkoh

@dzearing dzearing Awaiting requested review from dzearing

@aditima aditima Awaiting requested review from aditima

@Jahnp Jahnp Awaiting requested review from Jahnp

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

@KevinTCoughlin KevinTCoughlin Awaiting requested review from KevinTCoughlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove TSlint overrides in OUFR
6 participants
@khmakoto @KevinTCoughlin @msft-github-bot @JasonGore @dzearing @aneeshack4