Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added consistent aria levels to any role='heading' #5782

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Added consistent aria levels to any role='heading' #5782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd3be68
Removed heading role from combo and contextualmenus, updated dialog a…
micahgodbolt Aug 2, 2018
22585ef
Changefile
micahgodbolt Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/update-aria-level_2018-08-02-22-33.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Removed unnecessary heading roles, and added aria-level to those requiring them",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ export class ComboBox extends BaseComponent<IComboBoxProps, IComboBoxState> {
const { onRenderOption = this._onRenderOptionContent } = this.props;

return (
<div key={item.key} className={this._classNames.header} role="heading">
<div key={item.key} className={this._classNames.header}>
{onRenderOption(item, this._onRenderOptionContent)}
</div>
);
Expand Down
9 changes: 2 additions & 7 deletions packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,7 @@ export class ContextualMenuBase extends BaseComponent<IContextualMenuProps, ICon
onKeyDown={this._onMenuKeyDown}
onKeyUp={this._onKeyUp}
>
{title && (
<div className={this._classNames.title} role="heading" aria-level={1}>
{' '}
{title}{' '}
</div>
)}
{title && <div className={this._classNames.title}> {title} </div>}
{items && items.length ? (
<FocusZone
{...this._adjustedFocusZoneProps}
Expand Down Expand Up @@ -574,7 +569,7 @@ export class ContextualMenuBase extends BaseComponent<IContextualMenuProps, ICon
const { contextualMenuItemAs: ChildrenRenderer = ContextualMenuItem } = this.props;

return (
<div className={this._classNames.header} style={item.style} role="heading" aria-level={this.props.title ? 2 : 1}>
<div className={this._classNames.header} style={item.style}>
<ChildrenRenderer
item={item}
classNames={classNames}
Expand Down
6 changes: 4 additions & 2 deletions packages/office-ui-fabric-react/src/components/Dialog/DialogContent.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,13 @@ export class DialogContentBase extends BaseComponent<IDialogContentProps, {}> {
return (
<div className={classNames.content}>
<div className={classNames.header}>
<p className={classNames.title} id={titleId} role="heading">
<p className={classNames.title} id={titleId} role="heading" aria-level={2}>
{title}
</p>
<div className={classNames.topButton}>
{this.props.topButtonsProps!.map((props, index) => <IconButton key={props.uniqueId || index} {...props} />)}
{this.props.topButtonsProps!.map((props, index) => (
<IconButton key={props.uniqueId || index} {...props} />
))}
{(type === DialogType.close || (showCloseButton && type !== DialogType.largeHeader)) && (
<IconButton
className={classNames.button}
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Dialog/__snapshots__/Dialog.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ exports[`Dialog renders Dialog correctly 1`] = `
}
>
<p
aria-level={2}
className=
ms-Dialog-title
{
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Panel/Panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ export class Panel extends BaseComponent<IPanelProps, IPanelState> implements IP
className={css('ms-Panel-headerText', styles.headerText, headerClassName)}
id={headerTextId}
role="heading"
aria-level={2}
>
{headerText}
</p>
Expand Down