Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-file-type-icons): Map onepart extension to onenote icon #33318

Conversation

cpalaparthi
Copy link
Contributor

Previous Behavior

onepart extension is mapped to genericfile (fallback) as it is not present in FileTypeIconMap.

New Behavior

onepart extension is now mapped to one extension.

Related Issue(s)

Copy link

github-actions bot commented Nov 21, 2024

📊 Bundle size report

✅ No changes found

@cpalaparthi
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

Copy link

Pull request demo site: URL

@cpalaparthi
Copy link
Contributor Author

cpalaparthi commented Nov 21, 2024

image

Copy link
Contributor

@bigbadcapers bigbadcapers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks correct, thanks for this improvement! Approved.

@spmonahan spmonahan merged commit 999db8c into microsoft:master Nov 21, 2024
11 checks passed
@cpalaparthi cpalaparthi deleted the cpalaparthiadd-onepart-extension-to-filetypeiconmap branch November 21, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants