Added styles to the styled legends story #33246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anush <[email protected]>
Co-authored-by: Anush <[email protected]>
…luentui into usr/atisjai/chartsV9
…luentui into usr/atisjai/chartsV9
AtishayMsft
requested review from
AtishayMsft
and removed request for
a team
AtishayMsft
reviewed
Nov 11, 2024
packages/charts/react-charts-preview/library/src/components/Legends/Legends.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Nov 13, 2024
| @@ -1,5 +1,12 @@ | |||
| import * as React from 'react'; | |||
| import { Legend, Legends, getColorFromToken, DataVizPalette } from '@fluentui/react-charts-preview'; | |||
| import { makeStyles } from '@griffel/react'; | |||
There was a problem hiding this comment.
use makestyles from react-components in stories file.
AtishayMsft
reviewed
Nov 13, 2024
| */ | ||
| className?: string; | ||
| className?: LegendsStyles; |
There was a problem hiding this comment.
We need to keep the type as LegendStyles so that the classNames can be applied to all the sub-components as well. Otherwise, it can be applied to root only.
|
Pull request demo site: URL |
tudorpopams
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added styles to the styled legends story
