Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workspace-plugin): add generateApi functionality/flag to build executor #32976

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat(workspace-plugin): add generateApi functionality/flag to build executor #32976

merged 3 commits into from
Oct 10, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 3, 2024 •
edited
Loading

Previous Behavior

New Behavior

  • adds new generateApi configuration flag in order to run generate-api executor as part of build executor
  • adds e2e test incorporating tsc and api-extractor invocation
  • refactors orchestration in a composable way within the build executor

Related Issue(s)

@github-actions github-actions bot added this to the October Project Cycle Q4 2024 milestone Oct 3, 2024
@Hotell Hotell mentioned this pull request Oct 3, 2024
Closed
39 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 3, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@Hotell Hotell changed the title feat(workspace-plugin): add generateAPI within build executor feat(workspace-plugin): add generateApi functionality/flag to build executor Oct 4, 2024
@Hotell Hotell force-pushed the nx/workspace-plugin/build-executor-2 branch from 94735e8 to ffaabeb Compare October 7, 2024 11:29
@Hotell Hotell marked this pull request as ready for review October 7, 2024 12:57
@Hotell Hotell requested a review from a team as a code owner October 7, 2024 12:57
@Hotell Hotell requested a review from marcosmoura October 8, 2024 12:12
marcosmoura
marcosmoura approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@marcosmoura marcosmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work here!

@Hotell Hotell merged commit de0eb04 into microsoft:master Oct 10, 2024
20 checks passed
@Hotell Hotell deleted the nx/workspace-plugin/build-executor-2 branch October 10, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees
No one assigned
Labels
NX: workspace executors
Projects
None yet
Milestone
October Project Cycle Q4 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @marcosmoura