Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update fast-element to latest stable version #32344

Conversation

chrisdholt
Copy link
Member

New Behavior

Updates the @microsoft/fast-element dependency to the latest stable version.

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 612 627 5000
Button mount 292 310 5000
Field mount 1164 1069 5000
FluentProvider mount 685 695 5000
FluentProviderWithTheme mount 77 82 10
FluentProviderWithTheme virtual-rerender 35 29 10
FluentProviderWithTheme virtual-rerender-with-unmount 71 72 10
MakeStyles mount 822 816 50000
Persona mount 1699 1643 5000
SpinButton mount 1381 1328 5000
SwatchPicker mount 1542 1545 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
DividerMinimalPerf.default 224 200 1.12:1
TextMinimalPerf.default 211 190 1.11:1
TreeWith60ListItems.default 93 84 1.11:1
ProviderMinimalPerf.default 221 201 1.1:1
FlexMinimalPerf.default 162 149 1.09:1
LoaderMinimalPerf.default 199 182 1.09:1
FormMinimalPerf.default 236 219 1.08:1
ListNestedPerf.default 343 317 1.08:1
SegmentMinimalPerf.default 211 196 1.08:1
ButtonMinimalPerf.default 90 84 1.07:1
InputMinimalPerf.default 571 534 1.07:1
DropdownMinimalPerf.default 1468 1384 1.06:1
IconMinimalPerf.default 384 361 1.06:1
AnimationMinimalPerf.default 309 293 1.05:1
ChatMinimalPerf.default 454 434 1.05:1
RadioGroupMinimalPerf.default 265 253 1.05:1
GridMinimalPerf.default 192 184 1.04:1
HeaderMinimalPerf.default 213 205 1.04:1
ListCommonPerf.default 400 385 1.04:1
TableManyItemsPerf.default 1116 1078 1.04:1
ItemLayoutMinimalPerf.default 708 690 1.03:1
MenuButtonMinimalPerf.default 964 933 1.03:1
ButtonSlotsPerf.default 325 318 1.02:1
HeaderSlotsPerf.default 450 441 1.02:1
ImageMinimalPerf.default 226 222 1.02:1
PopupMinimalPerf.default 355 347 1.02:1
RefMinimalPerf.default 115 113 1.02:1
BoxMinimalPerf.default 191 190 1.01:1
ChatDuplicateMessagesPerf.default 160 158 1.01:1
CheckboxMinimalPerf.default 1138 1125 1.01:1
DropdownManyItemsPerf.default 383 378 1.01:1
ListWith60ListItems.default 369 366 1.01:1
MenuMinimalPerf.default 508 504 1.01:1
PortalMinimalPerf.default 83 82 1.01:1
ProviderMergeThemesPerf.default 651 643 1.01:1
ReactionMinimalPerf.default 213 211 1.01:1
StatusMinimalPerf.default 391 387 1.01:1
ToolbarMinimalPerf.default 544 538 1.01:1
ChatWithPopoverPerf.default 207 207 1:1
DialogMinimalPerf.default 439 441 1:1
SkeletonMinimalPerf.default 202 202 1:1
TableMinimalPerf.default 232 231 1:1
CardMinimalPerf.default 312 315 0.99:1
CarouselMinimalPerf.default 257 260 0.99:1
DatepickerMinimalPerf.default 3538 3570 0.99:1
LabelMinimalPerf.default 215 218 0.99:1
RosterPerf.default 1566 1574 0.99:1
SplitButtonMinimalPerf.default 2241 2253 0.99:1
CustomToolbarPrototype.default 1495 1504 0.99:1
TooltipMinimalPerf.default 1301 1315 0.99:1
EmbedMinimalPerf.default 1893 1926 0.98:1
SliderMinimalPerf.default 726 741 0.98:1
AttachmentSlotsPerf.default 630 650 0.97:1
LayoutMinimalPerf.default 191 196 0.97:1
ListMinimalPerf.default 309 319 0.97:1
TreeMinimalPerf.default 474 488 0.97:1
VideoMinimalPerf.default 423 438 0.97:1
AccordionMinimalPerf.default 85 89 0.96:1
AlertMinimalPerf.default 154 160 0.96:1
AttachmentMinimalPerf.default 75 78 0.96:1
AvatarMinimalPerf.default 107 111 0.96:1
ButtonOverridesMissPerf.default 636 672 0.95:1
TextAreaMinimalPerf.default 293 314 0.93:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 641 635 5000
Breadcrumb mount 1769 1697 1000
Checkbox mount 1705 1704 5000
CheckboxBase mount 1484 1502 5000
ChoiceGroup mount 2952 3017 5000
ComboBox mount 686 682 1000
CommandBar mount 6608 6648 1000
ContextualMenu mount 11742 12085 1000
DefaultButton mount 797 823 5000
DetailsRow mount 2226 2238 5000
DetailsRowFast mount 2302 2304 5000
DetailsRowNoStyles mount 2058 2061 5000
Dialog mount 2732 2817 1000
DocumentCardTitle mount 233 239 1000
Dropdown mount 1972 2014 5000
FocusTrapZone mount 1160 1145 5000
FocusZone mount 1092 1066 5000
GroupedList mount 42436 43045 2
GroupedList virtual-rerender 20476 20499 2
GroupedList virtual-rerender-with-unmount 51953 52034 2
GroupedListV2 mount 247 229 2
GroupedListV2 virtual-rerender 203 220 2
GroupedListV2 virtual-rerender-with-unmount 229 235 2
IconButton mount 1139 1150 5000
Label mount 343 341 5000
Layer mount 2783 2768 5000
Link mount 392 403 5000
MenuButton mount 1003 979 5000
MessageBar mount 21386 21383 5000
Nav mount 2060 2071 1000
OverflowSet mount 793 785 5000
Panel mount 1904 1841 1000
Persona mount 735 751 1000
Pivot mount 912 901 1000
PrimaryButton mount 943 959 5000
Rating mount 4718 4690 5000
SearchBox mount 927 909 5000
Shimmer mount 1932 1887 5000
Slider mount 1364 1373 5000
SpinButton mount 3054 3057 5000
Spinner mount 399 392 5000
SplitButton mount 1925 1876 5000
Stack mount 437 422 5000
StackWithIntrinsicChildren mount 881 881 5000
StackWithTextChildren mount 2748 2796 5000
SwatchColorPicker mount 6448 6517 5000
TagPicker mount 1450 1454 5000
Text mount 385 385 5000
TextField mount 977 937 5000
ThemeProvider mount 857 883 5000
ThemeProvider virtual-rerender 588 588 5000
ThemeProvider virtual-rerender-with-unmount 1302 1281 5000
Toggle mount 625 617 5000
buttonNative mount 188 192 5000

@chrisdholt
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@chrisdholt chrisdholt enabled auto-merge (squash) August 20, 2024 22:53
@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@chrisdholt chrisdholt merged commit 7f10150 into microsoft:master Aug 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants