chore(web-components): [button] move style related api out of base class #32049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
radium-v
reviewed
Jul 18, 2024
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
radium-v
reviewed
Jul 18, 2024
radium-v
approved these changes
Jul 18, 2024
radium-v
changed the title
Co-authored-by: John Kreitlow <[email protected]>
mlijanto
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Style specific parts of Button's API were bundled into the class.
New Behavior
Style specific parts of Button's API are kept in the
Buttonclass while functional parts of the API are moved into a newBaseButtonclass. This allows consumers to opt out of style specifics they may not need.Related Issue(s)