Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support users setting tabindex attribute for button #32003

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: support users setting tabindex attribute for button #32003

merged 2 commits into from
Jul 15, 2024

Conversation

chrisdholt
Copy link
Member

Previous Behavior

Button ignored tabindex when set from user land

New Behavior

Buttons which are disabled are always tabindex of -1, otherwise default to tabIndex if provided or 0.

Related Issue(s)

  • Fixes #

@chrisdholt chrisdholt requested a review from a team as a code owner July 15, 2024 18:40
davatron5000
davatron5000 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@davatron5000 davatron5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chrisdholt chrisdholt enabled auto-merge (squash) July 15, 2024 18:45
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 15, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@chrisdholt chrisdholt force-pushed the users/chhol/support-manually-setting-tabindex-button branch from e3a5449 to 121c501 Compare July 15, 2024 19:16
@chrisdholt chrisdholt merged commit 294d82a into microsoft:master Jul 15, 2024
18 checks passed
@chrisdholt chrisdholt deleted the users/chhol/support-manually-setting-tabindex-button branch July 15, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@eljefe223 eljefe223 eljefe223 approved these changes

@janechu janechu janechu approved these changes

@radium-v radium-v radium-v approved these changes

@marchbox marchbox marchbox approved these changes

@mlijanto mlijanto mlijanto approved these changes

@davatron5000 davatron5000 davatron5000 approved these changes

Assignees
No one assigned
Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chrisdholt @fabricteam @davatron5000 @mlijanto @marchbox @radium-v @janechu @eljefe223