Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to nx 19.3.2 #31892

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 1, 2024

Previous Behavior

New Behavior

  • see PR title
  • latest stable v19

Related Issue(s)

@Hotell Hotell changed the title Nx/migrate/19 3 chore: migrate to nx 19.3.2 Jul 1, 2024
@Hotell Hotell added the NX: core label Jul 1, 2024
.gitignore Outdated Show resolved Hide resolved
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 1, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 654 619 5000
Button mount 296 303 5000
Field mount 1112 1130 5000
FluentProvider mount 701 715 5000
FluentProviderWithTheme mount 79 88 10
FluentProviderWithTheme virtual-rerender 35 33 10
FluentProviderWithTheme virtual-rerender-with-unmount 74 73 10
MakeStyles mount 876 880 50000
Persona mount 1772 1734 5000
SpinButton mount 1401 1358 5000
SwatchPicker mount 1634 1667 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 1, 2024

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 136 108 1.26:1
ButtonMinimalPerf.default 93 82 1.13:1
ChatDuplicateMessagesPerf.default 158 140 1.13:1
AttachmentMinimalPerf.default 86 78 1.1:1
CarouselMinimalPerf.default 268 248 1.08:1
LayoutMinimalPerf.default 206 191 1.08:1
ReactionMinimalPerf.default 226 209 1.08:1
TableMinimalPerf.default 239 221 1.08:1
ProviderMinimalPerf.default 203 190 1.07:1
BoxMinimalPerf.default 203 191 1.06:1
CardMinimalPerf.default 303 286 1.06:1
ImageMinimalPerf.default 222 210 1.06:1
TreeWith60ListItems.default 86 81 1.06:1
HeaderMinimalPerf.default 208 199 1.05:1
AnimationMinimalPerf.default 311 300 1.04:1
ChatMinimalPerf.default 426 410 1.04:1
FlexMinimalPerf.default 155 149 1.04:1
ListCommonPerf.default 387 373 1.04:1
ListMinimalPerf.default 310 298 1.04:1
ListNestedPerf.default 330 316 1.04:1
SkeletonMinimalPerf.default 194 187 1.04:1
VideoMinimalPerf.default 431 414 1.04:1
AlertMinimalPerf.default 165 160 1.03:1
ButtonOverridesMissPerf.default 642 621 1.03:1
ButtonSlotsPerf.default 306 296 1.03:1
ChatWithPopoverPerf.default 190 185 1.03:1
FormMinimalPerf.default 229 223 1.03:1
LoaderMinimalPerf.default 197 191 1.03:1
SegmentMinimalPerf.default 195 189 1.03:1
TreeMinimalPerf.default 479 464 1.03:1
DividerMinimalPerf.default 209 204 1.02:1
GridMinimalPerf.default 192 188 1.02:1
MenuMinimalPerf.default 494 485 1.02:1
RosterPerf.default 1582 1546 1.02:1
PopupMinimalPerf.default 346 340 1.02:1
SliderMinimalPerf.default 749 734 1.02:1
TextMinimalPerf.default 199 195 1.02:1
TextAreaMinimalPerf.default 297 290 1.02:1
AccordionMinimalPerf.default 84 83 1.01:1
AttachmentSlotsPerf.default 644 635 1.01:1
ItemLayoutMinimalPerf.default 706 700 1.01:1
ProviderMergeThemesPerf.default 637 629 1.01:1
RadioGroupMinimalPerf.default 266 263 1.01:1
CustomToolbarPrototype.default 1465 1452 1.01:1
TooltipMinimalPerf.default 1264 1253 1.01:1
CheckboxMinimalPerf.default 1123 1125 1:1
DatepickerMinimalPerf.default 3486 3473 1:1
DialogMinimalPerf.default 441 443 1:1
ListWith60ListItems.default 367 367 1:1
SplitButtonMinimalPerf.default 2234 2227 1:1
StatusMinimalPerf.default 385 385 1:1
TableManyItemsPerf.default 1095 1096 1:1
DropdownManyItemsPerf.default 384 388 0.99:1
EmbedMinimalPerf.default 1858 1882 0.99:1
LabelMinimalPerf.default 216 219 0.99:1
ToolbarMinimalPerf.default 525 530 0.99:1
DropdownMinimalPerf.default 1399 1431 0.98:1
HeaderSlotsPerf.default 467 475 0.98:1
InputMinimalPerf.default 522 534 0.98:1
PortalMinimalPerf.default 82 84 0.98:1
MenuButtonMinimalPerf.default 927 955 0.97:1
IconMinimalPerf.default 368 382 0.96:1
RefMinimalPerf.default 105 111 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 1, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 1, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 1, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 636 624 5000
Breadcrumb mount 1692 1692 1000
Checkbox mount 1723 1692 5000
CheckboxBase mount 1463 1462 5000
ChoiceGroup mount 2998 2985 5000
ComboBox mount 685 675 1000
CommandBar mount 6558 6597 1000
ContextualMenu mount 11589 11622 1000
DefaultButton mount 817 792 5000
DetailsRow mount 2247 2229 5000
DetailsRowFast mount 2193 2246 5000
DetailsRowNoStyles mount 2043 1994 5000
Dialog mount 2749 2646 1000
DocumentCardTitle mount 240 218 1000
Dropdown mount 2001 2008 5000
FocusTrapZone mount 1172 1142 5000
FocusZone mount 1096 1063 5000
GroupedList mount 37802 42158 2
GroupedList virtual-rerender 20228 20102 2
GroupedList virtual-rerender-with-unmount 50589 51046 2
GroupedListV2 mount 223 235 2
GroupedListV2 virtual-rerender 221 209 2
GroupedListV2 virtual-rerender-with-unmount 227 235 2
IconButton mount 1133 1133 5000
Label mount 336 341 5000
Layer mount 2832 2778 5000
Link mount 404 399 5000
MenuButton mount 993 1005 5000
MessageBar mount 21668 21643 5000
Nav mount 2055 2004 1000
OverflowSet mount 785 798 5000
Panel mount 1860 1861 1000
Persona mount 734 745 1000
Pivot mount 910 883 1000
PrimaryButton mount 929 926 5000
Rating mount 4675 4698 5000
SearchBox mount 944 904 5000
Shimmer mount 1906 1925 5000
Slider mount 1326 1364 5000
SpinButton mount 2977 3037 5000
Spinner mount 394 394 5000
SplitButton mount 1893 1884 5000
Stack mount 429 434 5000
StackWithIntrinsicChildren mount 859 867 5000
StackWithTextChildren mount 2807 2780 5000
SwatchColorPicker mount 6393 6327 5000
TagPicker mount 1505 1464 5000
Text mount 384 387 5000
TextField mount 954 971 5000
ThemeProvider mount 878 861 5000
ThemeProvider virtual-rerender 578 580 5000
ThemeProvider virtual-rerender-with-unmount 1309 1290 5000
Toggle mount 613 618 5000
buttonNative mount 195 194 5000

.gitignore Outdated Show resolved Hide resolved
@Hotell Hotell mentioned this pull request Jul 1, 2024
39 tasks
@Hotell Hotell marked this pull request as ready for review July 2, 2024 15:09
@Hotell Hotell requested a review from a team as a code owner July 2, 2024 15:09
@Hotell Hotell requested a review from dmytrokirpa July 3, 2024 12:03
@Hotell Hotell merged commit ef3591c into microsoft:master Jul 4, 2024
21 checks passed
@Hotell Hotell deleted the nx/migrate/19_3 branch July 4, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants