feat: update text to use element internals for custom states #31770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
force-pushed
the
users/chhol/update-text-with-element-internals
branch
from
a4edf65
to
1352d8b
Compare
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 19, 2024
change/@fluentui-web-components-891d02bb-a945-4c7a-8e7b-a89567483de0.json
Show resolved
Hide resolved
chrisdholt
force-pushed
the
users/chhol/update-text-with-element-internals
branch
from
1352d8b
to
7f6857f
Compare
janechu
reviewed
Jun 20, 2024
chrisdholt
force-pushed
the
users/chhol/update-text-with-element-internals
branch
2 times, most recently
from
3af03a1
to
670d999
Compare
chrisdholt
force-pushed
the
users/chhol/update-text-with-element-internals
branch
from
670d999
to
bbb0a64
Compare
davatron5000
approved these changes
Jun 24, 2024
Co-authored-by: Dave Rupert <[email protected]>
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 26, 2024
* master: (90 commits) fix(react-drawer): do not create global header/footer roles (microsoft#31799) release: applying package updates - react v8 release: applying package updates - web-components Add 'allowParentArrowNavigation' prop to `ComboBox`. (microsoft#31805) Add drawer web component (microsoft#31521) fix: MenuButton is styled correctly when aria-expanded is a string (microsoft#31809) chore: Updating version of `@fluentui/react-icons` to `^2.0.245` (microsoft#31802) chore:(docs) Migrate e2e Cypress testing doc (microsoft#31796) chore:(docs) Update API Extractor file (microsoft#31651) chore: migrate to nx 18 (microsoft#31746) release: applying package updates - react v8 release: applying package updates - web-components feat: update text to use element internals for custom states (microsoft#31770) chore(web-components): Remove define imports from story modules (microsoft#31622) fix(`merge-styles`): Correctly processing selectors when value is a class name and they are not wrapped in `selectors` wrapper (microsoft#31798) style(react-combobox): turn off react-compiler lints for non compliant code (microsoft#31795) docs: Add AriaLiveAnnouncer to all examples (microsoft#31794) fix(public-docsite-v9): disable storybook keyboard shortcuts (microsoft#31762) feat: V0 Attachment compact component (microsoft#31634) release: applying package updates - react v8 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR updates the
Textcomponent to use Element Internals custom states for presentational attributes and provides an attribute fallback where not supported.Related Issue(s)