-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-motion): add support for params #31566
Merged
layershifter
merged 2 commits into
microsoft:master
from
layershifter:chore/motions-params
Jun 11, 2024
Merged
feat(react-motion): add support for params #31566
layershifter
merged 2 commits into
microsoft:master
from
layershifter:chore/motions-params
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 644 | 616 | 5000 | |
Button | mount | 305 | 304 | 5000 | |
Field | mount | 1145 | 1168 | 5000 | |
FluentProvider | mount | 705 | 713 | 5000 | |
FluentProviderWithTheme | mount | 85 | 88 | 10 | |
FluentProviderWithTheme | virtual-rerender | 38 | 35 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 77 | 10 | |
MakeStyles | mount | 864 | 855 | 50000 | |
Persona | mount | 1760 | 1710 | 5000 | |
SpinButton | mount | 1444 | 1371 | 5000 | |
SwatchPicker | mount | 1533 | 1555 | 5000 |
layershifter
force-pushed
the
chore/motions-params
branch
from
June 4, 2024 16:23
ec97398
to
3b9d802
Compare
fabricteam
reviewed
Jun 4, 2024
packages/react-components/react-motions-preview/src/factories/createMotionComponent.ts
Outdated
Show resolved
Hide resolved
layershifter
force-pushed
the
chore/motions-params
branch
2 times, most recently
from
June 7, 2024 08:24
0be9854
to
cfc152d
Compare
layershifter
changed the title
feat(motions): add support for params
feat(react-motion): add support for params
Jun 7, 2024
ling1726
approved these changes
Jun 7, 2024
robertpenner
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see this useful feature be formalized.
packages/react-components/react-motion/src/factories/createMotionComponent.ts
Outdated
Show resolved
Hide resolved
robertpenner
reviewed
Jun 7, 2024
packages/react-components/react-motion/src/factories/createPresenceComponent.ts
Outdated
Show resolved
Hide resolved
robertpenner
approved these changes
Jun 10, 2024
layershifter
force-pushed
the
chore/motions-params
branch
from
June 10, 2024 20:10
13369f1
to
54a83fa
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
…-and-drawer-compat * master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 11, 2024
* master: (43 commits) chore: remove react-alert from monorepo (microsoft#31642) docs(react-skeleton): extend Skeleton story with SkeletonItem examples (microsoft#31608) feat(react-motion): add support for params (microsoft#31566) applying package updates fix: show default title action in dialog body for modal dialogs (microsoft#31648) chore:(react-nav-preview)Remove redundant NavDrawerHeaderNav component. (microsoft#31646) Update Accordion Size story to allow collapsing (microsoft#31624) fix(react-accordion): deprecate navigation prop (microsoft#31587) fix: Drawer story accessibility fixes and docs update (microsoft#31570) feat:(react-nav-preview) Adds small size variant (microsoft#31589) feat: update divider to use element internals (microsoft#31627) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /3rd batch (microsoft#31601) chore:(docs) Adding Jest testing document (microsoft#31554) chore(react-components): split react libraries in two (/library and /stories) - teams-prg /2nd batch (microsoft#31600) build(deps): bump tar from 6.1.11 to 6.2.1 (microsoft#31633) applying package updates fix: allow updating of CSS properties when they are already defined (microsoft#31629) fix: corrects the border-color for switch when in the checked state on rest (microsoft#31628) chore: update Switch to leverage ElementInternals via Checkbox (microsoft#31613) chore: update temporarily codeowners for split-in-two migrated packages to maintain proper PR review assignemnt for outdated branches (microsoft#31616) ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Adds support for custom props (params) in motions to to
createMotionComponent()
&createPresenceComponent()
.Related Issue(s)
Fixes #31576.