fix(react-drawer): improve CSS performance by using makeResetStyles #29263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
reviewed
Sep 22, 2023
packages/react-components/react-drawer/src/shared/useDrawerBaseStyles.styles.ts
Outdated
Show resolved
Hide resolved
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 10 | 16 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 636 | 633 | 5000 | |
| Button | mount | 315 | 315 | 5000 | |
| Field | mount | 1133 | 1123 | 5000 | |
| FluentProvider | mount | 696 | 697 | 5000 | |
| FluentProviderWithTheme | mount | 85 | 89 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 78 | 67 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 85 | 80 | 10 | |
| InfoButton | mount | 10 | 16 | 5000 | Possible regression |
| MakeStyles | mount | 847 | 861 | 50000 | |
| Persona | mount | 1750 | 1721 | 5000 | |
| SpinButton | mount | 1366 | 1342 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 644cbb3:
|
📊 Bundle size reportUnchanged fixtures
|
Hotell
approved these changes
Sep 22, 2023
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4942c5f07e08f1061cc8a6b753cd668b05482151 (build) |
…s-classnames * master: chore: Updating @fluentui/react-icons to version 2.0.216 (microsoft#29151) Replace cxe-coastal with cxe-red in codeowners (microsoft#29248) feat(react-drawer): add support to override Dialog as slot (microsoft#29217) fix(react-tags-preview): update `handleTagDismiss` type (microsoft#29240) create TimePicker component (microsoft#29252) Create react-timepicker-compat-preview package (microsoft#29216) feat(react-tags-preview): add useCustomStyleHook_unstable to all components (microsoft#29237) Enable reflow for all cartesian chart examples (microsoft#29229)
marcosmoura
deleted the
fix/react-drawer/improve-performance-of-css-classnames
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Components were using
makeStylesfor everything.New Behavior
Components now only use
makeStylesfor dynamic classNames andmakeResetStylesfor fixed rules.Related Issue(s)