-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-tags-preview): add default aria-labelledby on InteractionTagSecondary #29234
Merged
YuanboXue-Amber
merged 6 commits into
microsoft:master
from
YuanboXue-Amber:yuanboxue/tag-1
Sep 25, 2023
Merged
feat(react-tags-preview): add default aria-labelledby on InteractionTagSecondary #29234
YuanboXue-Amber
merged 6 commits into
microsoft:master
from
YuanboXue-Amber:yuanboxue/tag-1
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b658bc:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4942c5f07e08f1061cc8a6b753cd668b05482151 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
YuanboXue-Amber
force-pushed
the
yuanboxue/tag-1
branch
from
September 22, 2023 14:06
069aa03
to
661ba1b
Compare
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
bsunderhus
approved these changes
Sep 25, 2023
...mponents/react-tags-preview/src/components/InteractionTagPrimary/useInteractionTagPrimary.ts
Show resolved
Hide resolved
layershifter
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29219
Before this change:
User needs to set aria-labelledby on InteractionTagSecondary to make it compute accessible name that contains information from InteractionTagPrimary:
After this change:
InteractionTag creates id for InteractionTagPrimary, and pass it thru context. InteractionTagSecondary now has default
aria-labelledby=`${primaryId} ${secondaryId}`
. And user only needs to set a short aria-label: