Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: selector slot required when selection mode is defined #28648

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jul 26, 2023

Previous Behavior

New Behavior

  1. makes selector slot required whenever the selection mode is defined, to ensure slot creation
image

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the July Project Cycle Q3 2023 milestone Jul 26, 2023
@bsunderhus bsunderhus self-assigned this Jul 26, 2023
@bsunderhus bsunderhus marked this pull request as ready for review July 26, 2023 09:44
@bsunderhus bsunderhus requested a review from a team as a code owner July 26, 2023 09:44
@bsunderhus bsunderhus enabled auto-merge (squash) July 26, 2023 09:47
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 8 8 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 605 592 5000
Button mount 289 288 5000
Field mount 1060 1012 5000
FluentProvider mount 652 653 5000
FluentProviderWithTheme mount 78 76 10
FluentProviderWithTheme virtual-rerender 65 65 10
FluentProviderWithTheme virtual-rerender-with-unmount 70 69 10
InfoButton mount 8 8 5000 Possible regression
MakeStyles mount 841 852 50000
Persona mount 1683 1564 5000
SpinButton mount 1316 1349 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
67.576 kB
18.225 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.472 kB
57.814 kB
react-components
react-components: FluentProvider & webLightTheme
36.409 kB
12.003 kB
react-portal-compat
PortalCompatProvider
6.48 kB
2.203 kB
🤖 This report was generated against dab84e1d92c9ed5c2f60a82873b180eca069b792

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a1979c0:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 26, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: dab84e1d92c9ed5c2f60a82873b180eca069b792 (build)

@bsunderhus bsunderhus merged commit 0e9c438 into microsoft:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants